Skip to content

Update bundled jQuery to version 3.5.1 #21572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wenz opened this issue May 7, 2020 · 1 comment
Closed

Update bundled jQuery to version 3.5.1 #21572

wenz opened this issue May 7, 2020 · 1 comment
Assignees
@captainsafia
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one
Milestone
Test failures

Comments

@wenz
Copy link
Contributor

wenz commented May 7, 2020

The repository contains several instances of jQuery 3.4.1 (due to the fix for issue #20001).
jQuery 3.5.0 was released last month, which also fixed two security vulnerabilities (CVE-2020-11022 & CVE-2020-11023).
However, jQuery 3.5.0 came with a regression affecting many other JavaScript libraries (cf. https://blog.jquery.com/2020/05/04/jquery-3-5-1-released-fixing-a-regression/). jQuery 3.5.1 fixes that regression, so this version is fit to use for us.

PR is coming up later today ...
wenz added a commit to wenz/aspnetcore that referenced this issue May 7, 2020
@wenz
Upgrade jQuery in sample to version 3.5.1
ecec930 
Fixes dotnet#21572
@wenz wenz mentioned this issue May 7, 2020
Merged
@javiercn javiercn added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label May 7, 2020
@mkArtakMSFT mkArtakMSFT added the enhancement This issue represents an ask for new feature or an enhancement to an existing one label May 7, 2020
@mkArtakMSFT
Copy link
Contributor

Thanks @wenz.
We will review the PR in approximately a week and will continue the conversation there.

@mkArtakMSFT mkArtakMSFT added this to the Next sprint planning milestone May 7, 2020
@captainsafia captainsafia mentioned this issue May 13, 2020
Merged
captainsafia pushed a commit that referenced this issue May 13, 2020
@wenz @captainsafia
Upgrade jQuery in samples to version 3.5.1 (#21577)
fa38de0 
Fixes #21572
captainsafia pushed a commit that referenced this issue May 14, 2020
@wenz @captainsafia
Upgrade jQuery in samples to version 3.5.1 (#21577)
ac51988 
Fixes #21572
@ghost ghost locked as resolved and limited conversation to collaborators Jun 6, 2020
wtgodbe pushed a commit that referenced this issue Jun 10, 2020
@captainsafia @wenz
Upgrade jQuery in samples to version 3.5.1 (#21577) (#21792)
55822ca 
Fixes #21572

Co-authored-by: Christian Wenz <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@captainsafia captainsafia

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one
Projects
None yet
Milestone
Test failures
Development

No branches or pull requests
4 participants
@wenz @captainsafia @javiercn @mkArtakMSFT