Skip to content

Move various parsers/formatters into HttpAbstractions #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aspnet-hello opened this issue Jan 1, 2018 · 6 comments
Closed

Move various parsers/formatters into HttpAbstractions #2324

aspnet-hello opened this issue Jan 1, 2018 · 6 comments
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-http-abstractions

Comments

@aspnet-hello
Copy link

aspnet-hello commented Jan 1, 2018

From @davidfowl on Saturday, August 19, 2017 2:37:24 PM

In our continued effort to provide generally useful abstractions for the greater ecosystem, we should move the low level parsers and formatters into Microsoft.AspNetCore.WebUtilities.

HTTP Parser from Kestrel - https://github.com/aspnet/KestrelHttpServer/blob/59b77bb357f50946ecea310feb8db53473e0e165/src/Kestrel.Core/Internal/Http/HttpParser.cs

The chunked encoding parser from Kestrel - https://github.com/aspnet/KestrelHttpServer/blob/59b77bb357f50946ecea310feb8db53473e0e165/src/Kestrel.Core/Internal/Http/MessageBody.cs#L475

HPackEncoder and HpackDecoder - https://github.com/aspnet/KestrelHttpServer/blob/59b77bb357f50946ecea310feb8db53473e0e165/src/Kestrel.Core/Internal/Http2/HPack/HPackDecoder.cs
https://github.com/aspnet/KestrelHttpServer/blob/59b77bb357f50946ecea310feb8db53473e0e165/src/Kestrel.Core/Internal/Http2/HPack/HPackEncoder.cs

Copied from original issue: aspnet/HttpAbstractions#916

@aspnet-hello aspnet-hello added this to the 2.2.0 milestone Jan 1, 2018
@aspnet-hello
Copy link
Author

From @muratg on Monday, October 30, 2017 10:41:22 AM

@davidfowl putting this into the next milestone.

Was Managed HttpClient a potential user of this in your mind? Any other users?

@aspnet-hello
Copy link
Author

From @daniel-white on Monday, November 13, 2017 8:28:46 AM

The multipart support would be nice to consider too!

@aspnet-hello
Copy link
Author

From @litichevskiydv on Monday, December 11, 2017 10:13:37 AM

Will it be possible to use output and input formatters such as JSON output formatters in the middlewares?

@aspnet-hello
Copy link
Author

From @khellang on Monday, December 11, 2017 10:30:50 AM

It might be soon; aspnet/Mvc#6822 (comment), aspnet/Diagnostics#346 and aspnet/Mvc#6998

@muratg
Copy link
Contributor

muratg commented Jan 30, 2019

@davidfowl Assigned to you in 3.0. Please close if you don't think we'll change things here.

@analogrelay
Copy link
Contributor

analogrelay commented May 21, 2019

🤷‍♂

This doesn't really seem super relevant to us in the near term.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-http-abstractions
Projects
None yet
Development

No branches or pull requests

6 participants