Skip to content

Remove obsolete options APIs #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aspnet-hello opened this issue Jan 1, 2018 · 6 comments
Closed

Remove obsolete options APIs #2401

aspnet-hello opened this issue Jan 1, 2018 · 6 comments
Assignees
@JunTaoLuo
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares Done This issue has been fixed feature-session task
Milestone
3.0.0-preview2

Comments

@aspnet-hello
Copy link

From @natemcmaster on Monday, July 3, 2017 11:59:25 AM

Follow-up to aspnet/Session#173

Remove the following obsolete APIs

SessionOptions
  .CookieName 
  .CookiePath
  .CookieDomain
  .CookieHttpOnly
  .CookieSecure

.SameSideMode already removed.

Copied from original issue: aspnet/Session#175
@aspnet-hello aspnet-hello added this to the 3.0.0 milestone Jan 1, 2018
@aspnet-hello
Copy link
Author

From @Tratcher on Monday, July 3, 2017 9:55:51 PM

SameSiteMode was new in this release and can just be removed, no need to obsolete it.

From: Nate McMaster [email protected]
Sent: Monday, July 3, 2017 11:59:26 AM
To: aspnet/Session
Cc: Subscribed
Subject: [aspnet/Session] Remove obsolete options APIs (#175)

Follow-up to #173aspnet/Session#173

Remove the following obsolete APIs

SessionOptions
.CookieName
.CookiePath
.CookieDomain
.CookieHttpOnly
.SameSiteMode
.CookieSecure

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubaspnet/Session#175, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABvJ9QoH5FAELnv8aobhhpPS0_fyGWvGks5sKToOgaJpZM4OMmaF.

@aspnet-hello
Copy link
Author

From @natemcmaster on Monday, July 3, 2017 10:45:01 PM

Good catch. PR to remove it for 2.0.0 aspnet/Session#176

@aspnet-hello aspnet-hello mentioned this issue Jan 1, 2018
Closed
@muratg muratg modified the milestones: 3.0.0-preview1, 3.0.0-preview2 Nov 30, 2018
@JunTaoLuo JunTaoLuo mentioned this issue Dec 12, 2018
Merged
@JunTaoLuo JunTaoLuo self-assigned this Dec 12, 2018
@JunTaoLuo JunTaoLuo added 2 - Working Done This issue has been fixed and removed 2 - Working labels Dec 12, 2018
@JunTaoLuo
Copy link
Contributor

JunTaoLuo commented Dec 13, 2018 •
edited
Loading

@Tratcher do you think this needs another announcement? We already made one for deprecating it: aspnet/Announcements#257.

@Tratcher
Copy link
Member

How about a added comment on that announcement that 3.0 is the version they're being removed in?

@JunTaoLuo
Copy link
Contributor

That's not really useful, the discoverability of that comment is negligible. Might as well create a new announcement if we were to bother at all.

@Tratcher
Copy link
Member

Anybody subscribed to announcements would be notified the same way for a comment as for a new issue.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
@amcasey amcasey added the area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares label Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JunTaoLuo JunTaoLuo

Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares Done This issue has been fixed feature-session task
Projects
None yet
Milestone
3.0.0-preview2
Development

No branches or pull requests
5 participants
@muratg @Tratcher @JunTaoLuo @amcasey @aspnet-hello