Skip to content

Remove obsolete options APIs #2418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aspnet-hello opened this issue Jan 1, 2018 · 2 comments
Closed

Remove obsolete options APIs #2418

aspnet-hello opened this issue Jan 1, 2018 · 2 comments
Assignees
@javiercn
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates breaking-change This issue / pr will introduce a breaking change, when resolved / merged. Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one
Milestone
3.0.0-preview3

Comments

@aspnet-hello
Copy link

aspnet-hello commented Jan 1, 2018 •
edited by mkArtakMSFT
Loading

From @natemcmaster on Monday, July 3, 2017 11:56:58 AM

Follow-up to aspnet/Antiforgery#148

Remove the following obsoleted APIs

AntiforgeryOptions
  .CookieName
  .CookieDomain 
  .CookiePath 
  .RequireSsl

Copied from original issue: aspnet/Antiforgery#149
@aspnet-hello aspnet-hello added this to the 3.0.0 milestone Jan 1, 2018
@aspnet-hello aspnet-hello added breaking-change This issue / pr will introduce a breaking change, when resolved / merged. enhancement This issue represents an ask for new feature or an enhancement to an existing one repo:Antiforgery labels Jan 1, 2018
@aspnet-hello aspnet-hello mentioned this issue Jan 1, 2018
Closed
@mkArtakMSFT
Copy link
Member

IMPORTANT: there are many other places where options are exposed which essentially need to be also removed.

@Eilon Eilon added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates and removed repo:Antiforgery labels Nov 7, 2018
ryanbrandenburg pushed a commit that referenced this issue Nov 27, 2018
@BrennanConroy
Add Redis support to E2E benchmarks (#2418)
948ebf3
@pranavkm
Copy link
Contributor

Fixed as part of #7459

@pranavkm pranavkm assigned javiercn and unassigned pranavkm Feb 14, 2019
@pranavkm pranavkm added Done This issue has been fixed and removed 1 - Ready labels Feb 14, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@javiercn javiercn

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates breaking-change This issue / pr will introduce a breaking change, when resolved / merged. Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one
Projects
None yet
Milestone
3.0.0-preview3
Development

No branches or pull requests
6 participants
@pranavkm @Eilon @ajaybhargavb @javiercn @mkArtakMSFT @aspnet-hello