Skip to content

Unskip UserSecret tests #25109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BrennanConroy opened this issue Aug 20, 2020 · 4 comments · Fixed by #43667
Closed

Unskip UserSecret tests #25109

BrennanConroy opened this issue Aug 20, 2020 · 4 comments · Fixed by #43667
Assignees
@BrennanConroy
Labels
affected-very-few This issue impacts very few customers area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI feature-user-secrets severity-minor This label is used by an internal tool task
Milestone
8.0-preview1

Comments

@BrennanConroy
Copy link
Member

BrennanConroy commented Aug 20, 2020 •
edited
Loading

dotnet/runtime#41117 caused some test failures in UserSecrets.

In order to unblock dep updates we are skipping the failing tests until the bug is fixed.

Skipped tests in #25090
@javiercn javiercn added area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI feature-user-secrets labels Aug 21, 2020
@mkArtakMSFT mkArtakMSFT added this to the Next sprint planning milestone Aug 27, 2020
@ghost
Copy link

ghost commented Aug 27, 2020

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@jkotalik jkotalik added affected-very-few This issue impacts very few customers severity-minor This label is used by an internal tool task labels Nov 9, 2020 — with ASP.NET Core Issue Ranking
BrennanConroy added a commit that referenced this issue Sep 29, 2021
@BrennanConroy
Un-skip SetSecrets
719a99d 
Test was skipped due to a bug in Runtime, should have been unskipped a year ago 😆 #25109
Also one of the oldest `test-failure` issues is pointing at this test #21413, I think we should close it, add the test to the normal runs again and see if it fails anymore.
@BrennanConroy BrennanConroy mentioned this issue Sep 29, 2021
Merged
@BrennanConroy
Copy link
Member Author

Done via #37101

@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
@halter73
Copy link
Member

halter73 commented Aug 31, 2022 •
edited
Loading

The Remove_Is_Case_Insensitive and Clear_Secrets tests are still skipped with this issue as the akip reason. I'm not sure if it should be unskipped. @BrennanConroy

@halter73 halter73 reopened this Aug 31, 2022
@halter73 halter73 removed this from the 7.0-preview1 milestone Aug 31, 2022
@BrennanConroy
Copy link
Member Author

I think they should be unskipped, they were 100% failing before I believe, so if they pass when unskipped then we should be good.

BrennanConroy added a commit that referenced this issue Aug 31, 2022
@BrennanConroy
Unskip tests now that Runtime bug is fixed
bd100e8 
Closes #25109
@BrennanConroy BrennanConroy added this to the 8.0-alpha1 milestone Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BrennanConroy BrennanConroy

Labels
affected-very-few This issue impacts very few customers area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI feature-user-secrets severity-minor This label is used by an internal tool task
Projects
None yet
Milestone
8.0-preview1
Development

Successfully merging a pull request may close this issue.

Unskip tests now that Runtime bug is fixed dotnet/aspnetcore
6 participants
@halter73 @adityamandaleeka @javiercn @BrennanConroy @jkotalik @mkArtakMSFT