Skip to content

Add out-of-proc test for request queue delegation #28396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shirhatti opened this issue Dec 4, 2020 · 5 comments · Fixed by #36677
Closed

Add out-of-proc test for request queue delegation #28396

shirhatti opened this issue Dec 4, 2020 · 5 comments · Fixed by #36677
Assignees
Labels
affected-very-few This issue impacts very few customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-httpsys severity-minor This label is used by an internal tool task
Milestone

Comments

@shirhatti
Copy link
Contributor

shirhatti commented Dec 4, 2020

All the Http.Sys tests only verify delegating requests between two different Http.Sys queues in the same process. There are some behavioral differences (such as #28336 ) that it would be good to validate

@ghost
Copy link

ghost commented Dec 4, 2020

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@jkotalik jkotalik added affected-very-few This issue impacts very few customers severity-minor This label is used by an internal tool task labels Dec 4, 2020 — with ASP.NET Core Issue Ranking
@adityamandaleeka
Copy link
Member

adityamandaleeka commented Sep 8, 2021

We should be able to get this in for 6 since test-only changes have a bit more runway. At the very least we should get the test done in main in the 6.0 timeline, even if we don't get it into the 6.0 branch

@shirhatti
Copy link
Contributor Author

How do I write an out-of-proc test? @Tratcher is there a comparable test I can look at?

@Tratcher
Copy link
Member

Tratcher commented Sep 8, 2021

Or here:

var deploymentParameters = new DeploymentParameters(

@Tratcher Tratcher modified the milestones: 6.0.0, 6.0-rc2 Sep 18, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affected-very-few This issue impacts very few customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-httpsys severity-minor This label is used by an internal tool task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants