Don't call HttpCloseUrlGroup if you didn't create it #28336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirhatti
requested review from
halter73,
jkotalik and
Tratcher
as code owners
ghost
added
the
|
Not sure how to test this 😕 |
|
This seems fine. If we really wanted to test it we could spin up a separate process for the delegator. We have tests like that in Hosting. |
Tratcher
approved these changes
Dec 4, 2020
This was referenced Dec 4, 2020
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
_createdbool to track whether we created or attached to the UrlGroup