DelegationRule.Dispose() unsets delegation property on the queue#28342
Merged
3 commits merged intoDec 11, 2020
Merged
Conversation
shirhatti
requested review from
Tratcher,
halter73 and
jkotalik
as code owners
ghost
added
the
Contributor
Author
|
58a7eb6...257fbc2 are from #28336. I'll rebase after that's merged |
shirhatti
force-pushed
the
shirhatti/unsetdelegationrule
branch
from
fe66034 to
c731036
Compare
Tratcher
reviewed
Dec 8, 2020
Tratcher
approved these changes
Dec 8, 2020
NGloreous
approved these changes
Dec 8, 2020
shirhatti
force-pushed
the
shirhatti/unsetdelegationrule
branch
from
526322c to
c9a362f
Compare
Contributor
Author
|
I didn't realize we flow commits from 5.0 to master. Since I merged my 5.0 PR first and happened to rebase this PR doesn't do anything. I'm still going to merge the one small nit that Chris requested in this PR though |
|
Hello @shirhatti! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
amcasey
added
area-networking
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #27126