Skip to content

DelegationRule.Dispose() unsets delegation property on the queue #28342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
3 commits merged into from
Dec 11, 2020
Merged

DelegationRule.Dispose() unsets delegation property on the queue #28342

3 commits merged into from
Dec 11, 2020

Conversation

shirhatti
Copy link
Contributor

Addresses #27126

@ghost ghost added the area-servers label Dec 3, 2020
@shirhatti
Copy link
Contributor Author

58a7eb6...257fbc2 are from #28336. I'll rebase after that's merged

@shirhatti shirhatti linked an issue Dec 3, 2020 that may be closed by this pull request
HttpSysRequestDelegationFeature - DelegationRule.Dipose() doesn't clean up delegation flag with http.sys #27126
Closed
@shirhatti shirhatti force-pushed the shirhatti/unsetdelegationrule branch from fe66034 to c731036 Compare December 4, 2020 00:56
Tratcher
Tratcher reviewed Dec 8, 2020
View reviewed changes
@shirhatti shirhatti mentioned this pull request Dec 8, 2020
Merged
@shirhatti shirhatti force-pushed the shirhatti/unsetdelegationrule branch from 526322c to c9a362f Compare December 10, 2020 22:44
@shirhatti
Copy link
Contributor Author

I didn't realize we flow commits from 5.0 to master. Since I merged my 5.0 PR first and happened to rebase this PR doesn't do anything. I'm still going to merge the one small nit that Chris requested in this PR though

@ghost
Copy link

ghost commented Dec 10, 2020

Hello @shirhatti!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit fc163be into master Dec 11, 2020
@ghost ghost deleted the shirhatti/unsetdelegationrule branch December 11, 2020 00:20
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@NGloreous NGloreous NGloreous approved these changes

@halter73 halter73 Awaiting requested review from halter73

@jkotalik jkotalik Awaiting requested review from jkotalik

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HttpSysRequestDelegationFeature - DelegationRule.Dipose() doesn't clean up delegation flag with http.sys
4 participants
@shirhatti @Tratcher @NGloreous @amcasey