[release/5.0] DelegationRule.Dispose() unsets delegation property on the queue#28514
Merged
Merged
Conversation
…from the target URL group and allows the delegation rule to be added back later on in the processes lifetime
shirhatti
requested review from
Tratcher,
halter73 and
jkotalik
as code owners
ghost
added
the
shirhatti
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
NGloreous
approved these changes
Dec 8, 2020
Member
|
Note #28342 is still pending. |
leecow
added
Servicing-approved
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
CI failures aren't from the most recent run, it's just being buggy. Merging. |
Member
jkotalik
reviewed
Dec 9, 2020
| _sourceQueueUrlGroup.UnSetDelegationProperty(Queue, throwOnError: false); | ||
| } | ||
| catch (ObjectDisposedException) { /* Server may have been shutdown */ } | ||
| Queue.UrlGroup.Dispose(); |
Contributor
There was a problem hiding this comment.
Why was the nullable check removed here?
jkotalik
approved these changes
Dec 9, 2020
amcasey
added
area-networking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting #28342 to 5.0
Description
When a new DelegationRule is created, SetDelegationProperty gets called to add a HttpServerDelegationProperty property flag to the RequestQueue owned/created by the process (i.e. not the RequestQueue the delegator is trying to delegate to). When a DelegationRule is disposed, this property flag is not unset. This keeps the delegator process linked to destination queue and prevents a new DelegationRule rule for the same from being created later on.
Customer impact
Backport requested by @NGloreous. Has been validated (and submitted) by him
Regression
No. This is a new feature introduced in 5.0
Risk
Very low.