[release/5.0] Don't call HttpCloseUrlGroup if you didn't create it #28511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirhatti
requested review from
halter73,
jkotalik and
Tratcher
as code owners
ghost
added
the
shirhatti
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
NGloreous
approved these changes
Dec 8, 2020
Tratcher
approved these changes
Dec 8, 2020
leecow
added
Servicing-approved
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #28336 to 5.0
Description
HttpSysRequestDelegationFeature - DelegationRule.Dispose() - Call to HttpCloseUrlGroup Fails with result ERROR_INVALID_PARAMETER
Customer impact
Backport requested by @NGloreous. Has been validated by him
Results in a null ref that the customer needs to catch if #28494 isn't merged
Regression
No. This is a new feature introduced in 5.0
Risk
Very low.