[release/5.0] Fix null ref in UrlGroup.Dispose due to logger not set #28494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirhatti
requested review from
halter73,
jkotalik and
Tratcher
as code owners
ghost
added
the
|
Missed some commits? |
shirhatti
force-pushed
the
shirhatti/nullrefinurlgroupdispose
branch
from
d9759eb to
73f4a53
Compare
Ahh. I always confuse cherry-pick A^..B for just A..B 😅 |
shirhatti
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
NGloreous
approved these changes
Dec 8, 2020
leecow
added
Servicing-approved
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #26983 to 5.0
Description
When disposing a DelegationRule, if the call to HttpCloseUrlGroup within UrlGroup.Dispose() fails then a NullReferenceException happens because _logger is not initialized in the constructor used by the HttpSysRequestDelegationFeature.
This could happen if the delegatee process crashes.
Customer impact
Customer needs to guard against the null ref with a try...catch.
Backport requested by @NGloreous. Has been validated (and submitted by him 😄)
Regression
No. This is a new feature introduced in 5.0
Risk
Very low.