Skip to content

Fix null ref in UrlGroup.Dispose due to logger not set #26983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Oct 22, 2020

Conversation

NGloreous
Copy link
Contributor

Summary of the changes (Less than 80 chars)

@dnfadmin
Copy link

dnfadmin commented Oct 16, 2020

CLA assistant check
All CLA requirements met.

@shirhatti
Copy link
Contributor

@NGloreous Can you please sign the CLA?

@Tratcher
Copy link
Member

And re-target to the master branch please? I don't expect this to get approved for 5.0 at this point. We might be able to backport it for servicing later.

@NGloreous NGloreous force-pushed the user/nglore/delegation/nullref branch from 2fb1311 to da6155e Compare October 16, 2020 22:43
@NGloreous NGloreous requested a review from a team October 16, 2020 22:43
@NGloreous NGloreous changed the base branch from release/5.0 to master October 16, 2020 22:43
@NGloreous
Copy link
Contributor Author

@shirhatti CLA signed.

@Tratcher updated to point to master. I wasn't quite sure what the process was to get this patched for 5.

@@ -326,6 +326,10 @@ private void SetFatalResponse(int status)

internal unsafe void Delegate(DelegationRule destination)
{
if (destination == null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nullability should do a better job of validating this. Could we remove this check given that it's a non-public API?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pranavkm HttpSys.FeatureContext.DelegateRequest which is public calls this method directly. I could move this check over there but figured it made more sense here since this is where it's used.

I don't quite get your point about nullability.

@shirhatti
Copy link
Contributor

I wasn't quite sure what the process was to get this patched for 5.

It's too late to get this patched for 5. Given that there's an obvious workaround it won't meet the bar

@NGloreous
Copy link
Contributor Author

@shirhatti what's the work around? If there are any issues in Dispose they will result in a null ref and no ability to have insight into the actual error.

@runfoapp runfoapp bot mentioned this pull request Oct 19, 2020
@dougbu dougbu removed their request for review October 22, 2020 21:21
@shirhatti
Copy link
Contributor

@NGloreous Can you rebase to fix the merge conflicts?

@NGloreous NGloreous force-pushed the user/nglore/delegation/nullref branch from da6155e to 3ac734b Compare October 22, 2020 21:59
@NGloreous
Copy link
Contributor Author

@NGloreous Can you rebase to fix the merge conflicts?

@shirhatti done.

@ghost
Copy link

ghost commented Oct 22, 2020

Hello @Tratcher!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 519d96b into dotnet:master Oct 22, 2020
@shirhatti shirhatti added this to the 6.0.0-alpha1 milestone Oct 22, 2020
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpSysRequestDelegationFeature - DelegationRule throws NullReferenceException on Dispose
7 participants