Skip to content

[release/2.1] transitive dependencies aren't lifted for tests in patch builds #29023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wtgodbe opened this issue Jan 4, 2021 · 3 comments
Closed

[release/2.1] transitive dependencies aren't lifted for tests in patch builds #29023

wtgodbe opened this issue Jan 4, 2021 · 3 comments
Assignees
@dougbu
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed

Comments

@wtgodbe
Copy link
Member

wtgodbe commented Jan 4, 2021

Imagine a test project Test, which references Project1, which references Project2. If we make a functional change to Project2 in a patch, the test project will not consume the updated project - it only consumes the live-built version of its direct dependencies. The transitive dependencies get resolved from the baseline, which points to the latest public version on nuget.org. We should check to make sure that this understanding of our behavior is accurate, and either tweak our logic or our testing policy in 2.1 to account for it.

CC @dotnet/aspnet-build
dougbu added a commit that referenced this issue Jan 5, 2021
@dougbu
[release/2.1] Do not escape cookie names in lookups
fd2f492 
- **Do Not Merge**
- undo an important part of #24264
- this is an attempt to demonstrate #29023
  - should show test indirect references let most tests keep working
@dougbu dougbu mentioned this issue Jan 5, 2021
Merged
@mkArtakMSFT mkArtakMSFT added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 5, 2021
dougbu added a commit that referenced this issue Jan 19, 2021
@dougbu
[release/2.1] Do not escape cookie names in lookups
761132c 
- **Do Not Merge**
- always fail `RequestCookieCollection.ContainsKey(...)` and `RequestCookieCollection.TryGetValue(...)`
- undo an important part of #24264 and demonstrate #29023 problem
  - shows many tests working despite break of an indirect reference
dougbu added a commit that referenced this issue Jan 19, 2021
@dougbu
Add @(ProjectReference) items for patched projects
fb95fbc 
- #29023
- ensure tests do not use baseline assemblies for projects in current patch
dougbu added a commit that referenced this issue Jan 26, 2021
@dougbu
[release/2.1] Do not escape cookie names in lookups
59ecf40 
- **Do Not Merge**
- always fail `RequestCookieCollection.ContainsKey(...)` and `RequestCookieCollection.TryGetValue(...)`
- undo an important part of #24264 and demonstrate #29023 problem
  - shows many tests working despite break of an indirect reference
dougbu added a commit that referenced this issue Jan 26, 2021
@dougbu
Add @(ProjectReference) items for patched projects
b4f09b3 
- #29023
- ensure tests do not use baseline assemblies for projects in current patch
dougbu added a commit that referenced this issue Jan 27, 2021
@dougbu
[release/2.1] Do not escape cookie names in lookups
dee7114 
- **Do Not Merge**
- always fail `RequestCookieCollection.ContainsKey(...)` and `RequestCookieCollection.TryGetValue(...)`
- undo an important part of #24264 and demonstrate #29023 problem
  - shows many tests working despite break of an indirect reference
dougbu added a commit that referenced this issue Jan 27, 2021
@dougbu
Add @(ProjectReference) items for patched projects
b8c2b78 
- #29023
- ensure tests do not use baseline assemblies for projects in current patch
dougbu added a commit that referenced this issue Jan 28, 2021
@dougbu
Add @(ProjectReference) items for patched projects
2c68337 
- #29023
- ensure tests do not use baseline assemblies for projects in current patch
dougbu added a commit that referenced this issue Feb 10, 2021
@dougbu
Add @(ProjectReference) items for patched projects (#29037)
7aef172 
- #29023
- ensure tests do not use baseline assemblies for projects in current patch
@dougbu
Copy link
Contributor

dougbu commented Feb 11, 2021

Resolved in 7aef172 / #29037

@dougbu dougbu closed this as completed Feb 11, 2021
@dougbu dougbu added the Done This issue has been fixed label Feb 11, 2021
@dougbu
Copy link
Contributor

dougbu commented Feb 11, 2021

My thanks to @Tratcher who made me aware of this issue

@Tratcher
Copy link
Member

🥳 I can break tests again.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dougbu dougbu

Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Tratcher @dougbu @wtgodbe @mkArtakMSFT