-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Flaky Various Blazor Template timeouts/failures #30882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for contacting us. |
Also will track related quarantined blazor template tests |
BlazorWasmHostedPwaTemplate_Works Status:
|
Finally got a chance to look at this, looks like things are passing again after todays latest SDK update by @captainsafia , not sure what this is indicating, but looking at some of these failures, the error is due to a missing method exception from string values in Http header dictionary. @Tratcher @dougbu @javiercn any ideas what might have been out of sync here? Could this be due to IdentityServer4 being in the call stack? But looks like something was busted for 2 weeks until we got an sdk update, might be good to understand the cause in still
|
IHeaderDictionary.get_Authorization are new properties added in 6.0. I'll ping you. |
@Tratcher and I chatted a bit, and looks like @dougbu you might have fixed this issue already with 07c6a62#diff-5ae897b6b974eb8d878b7a7635d5d59d478115e73dba09f3832adcbafb7d137a Where we weren't testing templates against the latest aspnet-shared-fx bits. This should be fixed by your PR over the weekend right? |
We had a window in which we weren't testing templates using the latest ASP.NET runtime and my PR this weekend fixed that issue. If it explains the remaining flakiness, we're good. |
Thanks @dougbu , I think that explains the drop to 0%, we still have a ways to go on the rest Status as of 5/11 for the various blazor template tests: Seems pretty reliable (failed 2 times out of 1698 - last 14 days - 99.88%) (Unknown because these were 0% for last 2 weeks) Broken due to missing method exception from 4/26 (sdk update?), seems healthy-ish after 5/11 sdk update (75-87% last 30 days) Mostly 30 second timeout failures, |
Moving this to preview 7, the retry PR once merged should give us more data to see how the tests behave with 3 retries, hopefully that will let us unquarantine some of these, but likely there will be more fixes/tweaks needed to get to an acceptable pass rate. |
* Upgrade `playwright-sharp-tool` https://www.nuget.org/packages/playwright-sharp-tool Contributes towards #30882. * Update to latest v1.16.1 from GitHub https://github.com/microsoft/playwright-dotnet/releases/tag/v1.16.1 * Update to use Microsoft.Playwright * Update references to reflect `Microsoft.Playwright` * Update dotnet-tools.json * Upgrade System.CommandLine * Adapt to breaking API changes in Playwright * Upgrade dotnet-serve * Add Microsoft.Playwright.CLI * Revert "Upgrade System.CommandLine" This reverts commit cc46e9c. * Fix build The build failed. Fix the build errors and run again. C:\h\w\AA180980\w\9ED808A4\e\RunTests\RunTests.csproj : warning NU1604: Project dependency Microsoft.Playwright does not contain an inclusive lower bound. Include a lower bound in the dependency version to ensure consistent restore results. C:\h\w\AA180980\w\9ED808A4\e\RunTests\TestRunner.cs(124,35): error CS7036: There is no argument given that corresponds to the required formal parameter 'arguments' of 'ProcessUtil.RunAsync(string, string, string?, string?, bool, IDictionary<string, string?>?, Action<string>?, Action<string>?, Action<int>?, CancellationToken)' [C:\h\w\AA180980\w\9ED808A4\e\RunTests\RunTests.csproj] * Remove semaphore for websocket events * Update playwrightSettings based on breaking changes * npx based playwright install * npm install playwright * Install node in helix env * Use DOTNET_ROLL_FORWARD with `dotnet` `playwright` tool * Cleanup * Update playwright tool usage * DOTNET_ROLL_FORWARD in TestRunner * Specify project dir * Playwright install without cli * Update TestRunner.cs * Update TestRunner.cs * Re-enable helix playwright tests * Upgrade Playwright to 1.17.3, CLI to 1.2.2 * Fix spacing * Remove DOTNET_ROLL_FORWARD * PR Feedback * Remove temp project workaround. * Fix package lowerbound issue * Update Versions.props * Update BrowserManager.cs * Remove `Installing Microsoft.Playwright.CLI` * Disable playwright tests in helix
Thanks for contacting us. We're moving this issue to the |
@TanayParikh do we still need this issue given the linked issue above? |
Closing as duplicate of #38818. |
Re-opening as this fails in the (non-helix) build agents too. |
It looks like almost any blazor template test can fail due to a shared fixture being used between them and it timing out.
Builds: https://dev.azure.com/dnceng/internal/_build/results?buildId=1033436&view=ms.vss-test-web.build-test-results-tab&runId=32069600&resultId=125477&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab
https://dev.azure.com/dnceng/public/_build/results?buildId=1035875&view=ms.vss-test-web.build-test-results-tab&runId=32132094&resultId=125303&paneView=debug
The text was updated successfully, but these errors were encountered: