error MSB4186: Invalid static method invocation syntax:

[Bartmax]

Describe the bug

When publishing I get this error:

error MSB4186: Invalid static method invocation syntax: "[MSBuild]::MakeRelative('$(MSBuildProjectDirectory)','$([MSBuild]::NormalizePath('wwwroot\/\videos\lkr_app-preview_1920x1080%2816,9%29_1.mp4'))')".

I can confirm the issue is because the filename is called: lkr_app-preview_1920x1080(16,9)_1.mp4 and the issue is having a comma , on it's name.

To Reproduce

I was able to reproduce by only including a file with a , on it's name: FileWithComma,InTheName.txt
Here's a repo with minimal repro commit: Bartmax/PublishBug@d3a9b96

Exceptions (if any)

C:\Program Files\dotnet\sdk\6.0.100-preview.3.21202.5\Sdks\Microsoft.NET.Sdk.Razor\build\netstandard2.0\Microsoft.NET.Sdk.Razor.StaticWebAssets.targets(540,9): error MSB4186: Invalid static method invocation syntax: "[MSBuild]::MakeRelative('$(MSBuildProjectDirectory)','$([MSBuild]::NormalizePath('wwwroot\/\FileWithComma,InTheName.txt'))')". Method '[MSBuild]::MakeRelative' not found. Static method invocation should be of the form: $([FullTypeName]::Method()), e.g. $([System.IO.Path]::Combine(`a`, `b`)). Check that all parameters are defined, are of the correct type, and are specified in the right order. [C:\Development\Experiments\PublishBug\Server\PublishBug.Server.csproj]

Bonus

Visual studio new Git user experience is not able to add the file alone, must be done manually using git.

dotnet --info

### Further technical details .NET SDK (reflecting any global.json): Version: 6.0.100-preview.3.21202.5 Commit: aee38a6dd4

Runtime Environment:
OS Name: Windows
OS Version: 10.0.19042
OS Platform: Windows
RID: win10-x64
Base Path: C:\Program Files\dotnet\sdk\6.0.100-preview.3.21202.5\

Host (useful for support):
Version: 6.0.0-preview.3.21201.4
Commit: 236cb21e3c

.NET SDKs installed:
5.0.100-rc.1.20452.10 [C:\Program Files\dotnet\sdk]
5.0.100-rc.2.20479.15 [C:\Program Files\dotnet\sdk]
5.0.103 [C:\Program Files\dotnet\sdk]
5.0.200-preview.20601.7 [C:\Program Files\dotnet\sdk]
5.0.200-preview.21077.7 [C:\Program Files\dotnet\sdk]
5.0.201 [C:\Program Files\dotnet\sdk]
6.0.100-preview.3.21202.5 [C:\Program Files\dotnet\sdk]

Error happens with NET 5 too.

[javiercn]

@Bartmax thanks for contacting us.

This might be a limitation regarded to this being done in MSBuild. I don't think there is an easy fix on our side (I might be wrong here) that doesn't involve writing a custom task.

If you want to try a fix for it in MSBuild, the right place would be here since this is part of the Razor SDK. That said, please let us know if you are interested before you do any work so that we can help with some pointers here.

We are parking this in the backlog for now to gather more feedback and see if more people is affected by this issue.

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

[Bartmax]

Hey @javiercn that totally makes sense.

For future reference

Make Relative Task
StaticWebAssets.targets

I would totally love to fix this, I'm ready for those pointers.
Thank you!

[javiercn]

@Bartmax cool, let me think a bit about it and I'll update the issue next week.

I'm currently busy with other work, but I'll look at it once I have some time to spare.

[javiercn]

@Bartmax apologies for not getting back to you.

I believe this is fixed in preview7/rc1 in projects targeting 6.0, let me know otherwise.

(In short, we no longer have this code).