Skip to content

Address JS to DotNet byte[] Interop API Review Feedback #34327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TanayParikh opened this issue Jul 14, 2021 · 0 comments
Closed

Address JS to DotNet byte[] Interop API Review Feedback #34327

TanayParikh opened this issue Jul 14, 2021 · 0 comments
Assignees
@TanayParikh
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed feature-blazor-jsinterop This issue is related to JSInterop in Blazor
Milestone
6.0-preview7

Comments

@TanayParikh
Copy link
Contributor

API review feedback:

Remove the pause and resume parameters:

ValueTask<Stream> OpenReadStreamAsync(long maxAllowedSize = 512000, CancellationToken cancellationToken = default);

Originally posted by @pranavkm in #33491 (comment)
@TanayParikh TanayParikh self-assigned this Jul 14, 2021
@TanayParikh TanayParikh added area-blazor Includes: Blazor, Razor Components feature-blazor-jsinterop This issue is related to JSInterop in Blazor labels Jul 14, 2021
@TanayParikh TanayParikh added this to the 6.0-preview6 milestone Jul 14, 2021
TanayParikh added a commit that referenced this issue Jul 14, 2021
@TanayParikh
Address JS to DotNet byte[] Interop API Review Feedback
64de230 
Fixes: #34327
@TanayParikh TanayParikh mentioned this issue Jul 14, 2021
Merged
pranavkm pushed a commit that referenced this issue Jul 15, 2021
@TanayParikh
Address JS to DotNet byte[] Interop API Review Feedback (#34328)
de63b91 
* Address `JS` to `DotNet` byte[] Interop API Review Feedback

Fixes: #34327

* Update RemoteJSDataStreamTest.cs

* Update JSRuntimeTest.cs
@dougbu dougbu closed this as completed in eccb20d Jul 15, 2021
@ghost ghost added Done This issue has been fixed and removed Working labels Jul 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2021
@mkArtakMSFT mkArtakMSFT added the bug This issue describes a behavior which is not expected - a bug. label Oct 18, 2021
3dots pushed a commit to 3dots/aspnetcore-Web.JS that referenced this issue Feb 19, 2024
@TanayParikh
Blazor WebAssembly & WebView JS to .NET Streaming Interop Support (#3…
38888ac 
…3986)

* Prototype Large File Upload Support Blazor

* Blob.slice Implementation

* Allow WASM to keep working

* Update CircuitStreamingInterop.ts

* PR Feedback

* Cleanup

* WASM

* WebView

* Webview Remove SendJSDataStream

* Refactor Shared Streaming Interop Code TS

* WebView DotNetObjectReference Based ReceiveData

* BaseJSDataStream Refactor

* E2E tests WASM

* Unhandled Exception

* ReceiveJSDataChunk using DotNet Object Reference for WASM/WebView

* WASM Unmarshalled Interop Support

* E2E tests

* Update BaseJSDataStream.cs

* PR Feedback

* Update Web(View, Assembly) to match interop followup items

* PR Feedback

* Updated Release .js

* Create Microsoft.JSInterop.WebAssembly.WarningSuppressions.xml

* Updated WASM/WebView Pull Based Implementation

* InputFile Updated Implementation

* Cleanup

* PR Feedback

* Remove ReadRequest

* PR Feedback II

* Tests

* PR Feedback

* Address `JS` to `DotNet` byte[] Interop API Review Feedback (#34328)

* Address `JS` to `DotNet` byte[] Interop API Review Feedback

Fixes: dotnet/aspnetcore#34327

* Update RemoteJSDataStreamTest.cs

* Update JSRuntimeTest.cs

* Final PR Feedback

* Fix WebView for large Files
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TanayParikh TanayParikh

Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed feature-blazor-jsinterop This issue is related to JSInterop in Blazor
Projects
None yet
Milestone
6.0-preview7
Development

No branches or pull requests
2 participants
@TanayParikh @mkArtakMSFT