Skip to content

HTTP/2 and HTTP/3: Response trailers collection not reset #34411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JamesNK opened this issue Jul 16, 2021 · 1 comment · Fixed by #37627
Closed

HTTP/2 and HTTP/3: Response trailers collection not reset #34411

JamesNK opened this issue Jul 16, 2021 · 1 comment · Fixed by #37627
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions bug This issue describes a behavior which is not expected - a bug. help wanted Up for grabs. We would accept a PR to help resolve this issue HTTP2 HTTP3
Milestone
.NET 7 Planning

Comments

@JamesNK
Copy link
Member

JamesNK commented Jul 16, 2021

HTTP/2 and HTTP/3 will cache and reuse streams.

If the trailers collection is set via IHttpResponseTrailersFeature.Trailer = newValue then that collections contents will be reset but the collection itself will still be the user collection.

More info: #34360 (comment)
@JamesNK JamesNK added bug This issue describes a behavior which is not expected - a bug. area-runtime HTTP2 HTTP3 labels Jul 16, 2021
@JamesNK JamesNK mentioned this issue Jul 16, 2021
Merged
@BrennanConroy BrennanConroy added this to the 6.0-rc1 milestone Jul 16, 2021
@adityamandaleeka adityamandaleeka added the help wanted Up for grabs. We would accept a PR to help resolve this issue label Aug 11, 2021
@ladeak
Copy link
Contributor

ladeak commented Oct 12, 2021

I am considering picking this up.

My understanding that Http2Stream's OnReset() or Initialize() method should just set null for the _userTrailers fields.

Would you agree to such approach?

@ladeak ladeak mentioned this issue Oct 17, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Nov 25, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions bug This issue describes a behavior which is not expected - a bug. help wanted Up for grabs. We would accept a PR to help resolve this issue HTTP2 HTTP3
Projects
None yet
Milestone
.NET 7 Planning
Development

Successfully merging a pull request may close this issue.

34411 HTTP/2 and HTTP/3: Response trailers collection not reset ladeak/aspnetcore
6 participants
@halter73 @adityamandaleeka @JamesNK @BrennanConroy @ladeak @amcasey