34411 HTTP/2 and HTTP/3: Response trailers collection not reset #37627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resetting user set Trailers on H2 and H3 Stream's OnReset() methods - Adding a unit tests that covers if the stream is reset or not
ladeak
requested review from
BrennanConroy,
halter73 and
Tratcher
as code owners
ghost
added
area-runtime
community-contribution
halter73
reviewed
Oct 19, 2021
|
|
||
| Assert.NotNull(trailersFirst); | ||
| Assert.NotNull(trailersSecond); | ||
| Assert.NotSame(trailersFirst, trailersSecond); |
There was a problem hiding this comment.
Can this test be merged with ResponseTrailers_MultipleStreams_Reset? It'd also be nice to get coverage in the HTTP/3 tests to verify that the built-in trailers dictionary is cleared if there isn't already.
There was a problem hiding this comment.
Yes, I can merge the two. Not sure what you mean by the HTTP3 part though.
EDIT: I think I know what you mean, ack
halter73
reviewed
Oct 19, 2021
src/Servers/Kestrel/test/InMemory.FunctionalTests/Http3/Http3ConnectionTests.cs
Outdated
Show resolved
Hide resolved
|
@ladeak Do you mind updating the PR with the suggestions? We'd like to merge this and appreciate your contribution! |
|
Yes, let me add the suggestion in the next few days. |
|
@shirhatti I have followed up on the comments and pushed an update. |
halter73
approved these changes
Oct 26, 2021
|
Thanks @ladeak! |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
34411 HTTP/2 and HTTP/3: Response trailers collection not reset
This is a follow up on discussion: "would the trailers field get reset between requests"
Description
Fixes #34411