Skip to content

Components.E2ETests.ServerTransportsTests Failing (not quarantined) #35481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
halter73 opened this issue Aug 19, 2021 · 5 comments
Closed

Components.E2ETests.ServerTransportsTests Failing (not quarantined) #35481

halter73 opened this issue Aug 19, 2021 · 5 comments
Assignees
@TanayParikh
Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed feature-blazor-server test-failure
Milestone
6.0-rc2

Comments

@halter73
Copy link
Member

halter73 commented Aug 19, 2021 •
edited
Loading

Components.E2ETests don't block the build, but having tests that nearly always fail isn't really helpful and it can make it look like there are issues with PRs to the unitiated.

The tests I'm about to skip are:

  1. Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests.ServerTransportsTest.ErrorIfWebSocketsConnectionIsRejected
  2. Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests.ServerTransportsTest.ErrorIfClientAttemptsWebSocketsWithServerOnLongPolling
  3. Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests.ServerTransportsTest.DefaultTransportsWorksWithWebSockets
  4. Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests.ServerTransportsTest.ErrorIfClientAttemptsLongPollingWithServerOnWebSockets

image

It looks like these weren't touched by #35414.

@SteveSandersonMS
@halter73 halter73 changed the title Unskip consistently failing Components.E2ETests Unskip consistently failing Components.E2ETests.ServerExecutionTests Aug 19, 2021
@halter73 halter73 mentioned this issue Aug 19, 2021
Closed
@javiercn javiercn added area-blazor Includes: Blazor, Razor Components feature-blazor-server labels Aug 19, 2021
@javiercn
Copy link
Member

@halter73 thanks for reporting this.

@TanayParikh are these the tests you wrote as part of the move to websockets only in Blazor server? Can you check what's going on with them?

@pranavkm pranavkm added this to the 6.0-rc2 milestone Aug 19, 2021
@TanayParikh TanayParikh changed the title Unskip consistently failing Components.E2ETests.ServerExecutionTests Unskip consistently failing Components.E2ETests.ServerTransportsTest Aug 19, 2021
@TanayParikh TanayParikh changed the title Unskip consistently failing Components.E2ETests.ServerTransportsTest Unskip consistently failing Components.E2ETests.ServerTransportsTests Aug 19, 2021
@TanayParikh TanayParikh changed the title Unskip consistently failing Components.E2ETests.ServerTransportsTests Components.E2ETests.ServerTransportsTests Failing (not quarantined) Aug 23, 2021
@TanayParikh
Copy link
Contributor

Updated title in light of the fact that the original quarantining PR was closed out in favor of #35559.

@TanayParikh
Copy link
Contributor

The tests started to fail as of 8/17.

image

The reporting seems to be limited (are we on a set schedule or should this be running for every PR?). Regardless, looked into the individual tests and they're all passing locally and I'm not seeing anything in particular that could be causing this.

It looks like these weren't touched by #35414.

The following component file was touched: https://github.com/dotnet/aspnetcore/pull/35414/files#diff-8f6bebcbc94c25aa5fc8a8af676c1a3f8fa4d9e257fef4fd5d08abe8e52ef09b but I don't believe this should be causing the issue. Additionally, this was merged 8/18 (day after tests started randomly failing).

@TanayParikh
Copy link
Contributor

Also, I'm seeing:

[Severe] http://127.0.0.1:1100/defaultTransport/Transports 0:0 Uncaught TypeError: Failed to fetch dynamically imported module: http:…ltTransport/Transports/BasicTestApp.lib.module.jsPage content:\r\n<head></head><body><root><!--Blazor:

which doesn't appear related to the test, but rather a general infra issue. Given these tests weren't actually quarantined, are there any objections to closing out this PR. I believe these should just get resolved by the overall testing infra changes we are making.

@TanayParikh
Copy link
Contributor

This pipeline has been disabled until there are larger infrastructural changes made to improve reliability. Closing this out as there isn't anything actionable as the tests pass consistently locally.

@ghost ghost added the Working label Aug 25, 2021
@TanayParikh TanayParikh added Done This issue has been fixed and removed Working labels Aug 25, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TanayParikh TanayParikh

Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed feature-blazor-server test-failure
Projects
None yet
Milestone
6.0-rc2
Development

No branches or pull requests
4 participants
@halter73 @pranavkm @javiercn @TanayParikh