Skip to content

Paint it green #35559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2021
Merged

Paint it green #35559

merged 3 commits into from
Aug 20, 2021

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Aug 20, 2021

No description provided.

@HaoK HaoK requested a review from a team as a code owner August 20, 2021 16:44
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 20, 2021
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's the right place to set it, but CI will confirm. Can you file an issue to undo this once @SteveSandersonMS gets the tests fixed?

@HaoK
Copy link
Member Author

HaoK commented Aug 20, 2021

@wtgodbe unfortunately I had to do some surgery and add a new parameter to flow continueOnError to the right place, hopefully this will work

Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants