Skip to content

Reduce size of the nuget fallback folder #3650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aspnet-hello opened this issue Oct 17, 2018 · 4 comments
Closed

Reduce size of the nuget fallback folder #3650

aspnet-hello opened this issue Oct 17, 2018 · 4 comments
Assignees
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed

Comments

@aspnet-hello
Copy link

From @natemcmaster on Friday, April 27, 2018 3:19:18 PM

The NuGet fallback folder for 2.1 is a whopping 1.01 GB once expanded on disk. This includes lots of packages that should be unnecessary to execute a .NET Core 2.1 application, but are still required to restore a .NET Core 2.1 application.

This includes:

  • multiple copies of the same package (Newtonsoft.Json 9, 10, and 11)
  • multiple versions of NETStandard.Library (1.6.0, 1.6.1, and 2.0.3)
  • a bunch of runtime.native.* specific packages. In theory, these should only be consumed when users are producing a self-contained app, but this is out of scope for the offline cache
  • 670 MB of .xml docs
  • 147 MB of .nupkg files (why are they needed -- the contents of the .nupkg have already been unzipped)

Result:

  • bloated Docker images
  • longer first-run experience required to expand all these files
  • wasted disk space on CI machines (xml docs are typically only used by IDEs)

More details

A peek inside. Here are the packages that consume the most disk space:

Also, here is a breakdown of the files inside:

Here are all the runtime.* specific nupkgs inside

Copied from original issue: aspnet/Universe#1124

@aspnet-hello aspnet-hello added this to the 3.0.0 milestone Oct 17, 2018
@aspnet-hello
Copy link
Author

From @natemcmaster on Tuesday, June 12, 2018 11:13:39 AM

cc @DamianEdwards @JunTaoLuo @weshaggard - you're already aware of this issue, but figured we could use this to keep track of ongoing investigation on this issue.

@aspnet-hello aspnet-hello added 1 - Ready area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework labels Oct 17, 2018
@aspnet-hello
Copy link
Author

From @weshaggard on Tuesday, June 12, 2018 12:26:58 PM

cc @Petermarcu

@aspnet-hello
Copy link
Author

@natemcmaster
Copy link
Contributor

This was completed with #4061, which reduces the size of the LZMA to about 20 MB. We will continue to make it even smaller with #3610

@natemcmaster natemcmaster added Done This issue has been fixed and removed 1 - Ready labels Nov 20, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed
Projects
None yet
Development

No branches or pull requests

2 participants