Flatten the dependency graph of Microsoft.AspNetCore.App #4061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implements RID-split packages for Microsoft.AspNetCore.App * Remove all nuspec dependencies of Microsoft.AspNetCore.App and collect all references into the package * Update shared fx deps.json generation to only include entries for the RID-specific metapackages * Include platform-specific packages in publish output
|
Build passes in the PR. Tests fail due to disk-space limitations in Azure Pipelines. I've built and tested locally and believe this is ready to merge. I'd like to get this in soon so we can get this into the SDK for further testing of FrameworkReference. |
muratg
reviewed
Nov 16, 2018
| @@ -23,7 +23,7 @@ | |||
| <PackageArtifact Include="Microsoft.AspNet.Identity.AspNetCoreCompat" Category="noship" /> | |||
| <PackageArtifact Include="Microsoft.AspNetCore.ApiAuthorization.IdentityServer" Category="noship" /> | |||
| <PackageArtifact Include="Microsoft.AspNetCore.App" Category="ship" /> | |||
| <PackageArtifact Include="runtime.$(SharedFxRid).Microsoft.AspNetCore.App" Category="noship" /> | |||
| <PackageArtifact Include="runtime.$(SharedFxRid).Microsoft.AspNetCore.App" Category="ship" /> | |||
There was a problem hiding this comment.
By design? Are we going to be shipping this as a package now?
There was a problem hiding this comment.
Yup, this is intentional. This is how standalone deployment works, and what the "runtime.json" file is for.
muratg
approved these changes
Nov 16, 2018
This was referenced Nov 20, 2018
natemcmaster
added
the
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way Microsoft.AspNetCore.App works to follow patterns set by Microsoft.NETCore.App. Instead of being a metapackage with dozens of dependencies, this package has no dependencies. It uses RID-splitting to deliver standalone assets for self-contained deployments.
Changes:
Note: the "reference assemblies" are actually the implementation assemblies. We'll replace these with true ref assemblies in a separate PR.
Notably, these related issues will be addressed in a separately #3609, #3610
FYI @dsplaisted @DustinCampbell @DamianEdwards