Skip to content

Remove AuthenticationManager in 3.0? #3999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
drieseng opened this issue Nov 10, 2018 · 3 comments
Closed

Remove AuthenticationManager in 3.0? #3999

drieseng opened this issue Nov 10, 2018 · 3 comments
Assignees
@HaoK
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer breaking-change This issue / pr will introduce a breaking change, when resolved / merged. Done This issue has been fixed
Milestone
3.0.0-preview2

Comments

@drieseng
Copy link
Contributor

Microsoft.AspNetCore.Http.Authentication.AuthenticationManager has been marked obsolete in 2.0.
Perhaps you should consider removing it (and related classes) in 3.0.
@Eilon Eilon added area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer breaking-change This issue / pr will introduce a breaking change, when resolved / merged. labels Nov 26, 2018
@Eilon
Copy link
Contributor

Eilon commented Dec 6, 2018

Please post an announcement when this is done.

@Eilon Eilon added this to the 3.0.0-preview2 milestone Dec 6, 2018
HaoK added a commit that referenced this issue Dec 7, 2018
@HaoK
Remove old 1.x auth stack
095afac 
Fixes #3999
@HaoK HaoK mentioned this issue Dec 7, 2018
Merged
HaoK added a commit that referenced this issue Dec 7, 2018
@HaoK
Remove old 1.x auth stack
39d0d64 
Fixes #3999
HaoK added a commit that referenced this issue Jan 9, 2019
@HaoK
Remove old 1.x auth stack
f809404 
Fixes #3999
@HaoK HaoK closed this as completed in #4485 Jan 9, 2019
HaoK added a commit that referenced this issue Jan 9, 2019
@HaoK
Remove old 1.x auth stack (#4485)
d7a7c65 
* Remove old 1.x auth stack

Fixes #3999
@HaoK HaoK added the Done This issue has been fixed label Jan 9, 2019
@Eilon
Copy link
Contributor

Eilon commented Jan 10, 2019

Need an announcement issue!

@HaoK
Copy link
Member

HaoK commented Jan 10, 2019

I updated the one fowler posted since he had one that covered part of this change already:

aspnet/Announcements#337

@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
IsaacSchemm pushed a commit to IsaacSchemm/ISchemm.AspNetCore.Authentication.Tumblr that referenced this issue Jan 10, 2020
@HaoK
Remove old 1.x auth stack (#4485)
463c1f5 
* Remove old 1.x auth stack

Fixes dotnet/aspnetcore#3999
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HaoK HaoK

Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer breaking-change This issue / pr will introduce a breaking change, when resolved / merged. Done This issue has been fixed
Projects
None yet
Milestone
3.0.0-preview2
Development

No branches or pull requests
3 participants
@Eilon @drieseng @HaoK