Skip to content

RateLimitingMiddleware test improvements #43298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wtgodbe opened this issue Aug 15, 2022 · 4 comments
Closed

RateLimitingMiddleware test improvements #43298

wtgodbe opened this issue Aug 15, 2022 · 4 comments
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-rate-limit Work related to use of rate limit primitives help candidate Indicates that the issues may be a good fit for community to help with. Requires work from eng. team
Milestone
Backlog

Comments

@wtgodbe
Copy link
Member

wtgodbe commented Aug 15, 2022

Update https://github.com/dotnet/aspnetcore/blob/main/src/Middleware/RateLimiting/test/RateLimitingMiddlewareTests.cs to use RateLimiterEndpointConventionBuilderExtensions where appropriate (see #43053)
@wtgodbe wtgodbe added this to the 7.0-rc2 milestone Aug 15, 2022
@wtgodbe wtgodbe self-assigned this Aug 15, 2022
@wtgodbe wtgodbe mentioned this issue Aug 15, 2022
Merged
@wtgodbe wtgodbe modified the milestones: 7.0-rc2, Backlog Sep 7, 2022
@wtgodbe wtgodbe added the help wanted Up for grabs. We would accept a PR to help resolve this issue label Sep 7, 2022
@ghost
Copy link

ghost commented Sep 7, 2022

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@wtgodbe wtgodbe removed their assignment Sep 7, 2022
@MadL1me MadL1me mentioned this issue Dec 11, 2022
Merged
@MadL1me
Copy link
Contributor

MadL1me commented Dec 11, 2022

@wtgodbe I read #43053 and created improvement on rate limiter tests. I hope I did everything right, and I would appreciate if you look at my PR

MadL1me added a commit to MadL1me/aspnetcore that referenced this issue Dec 12, 2022
@MadL1me
dotnet#43298 - Improved rate limiting tests
dd3ef30
wtgodbe pushed a commit that referenced this issue Dec 12, 2022
@MadL1me
Improved rate limiting tests (#45541)
88ba76b 
* #43298 - Improved rate limiting tests

* Code review fixes: Removed project from filter, renamed file
@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
@mkArtakMSFT mkArtakMSFT added help candidate Indicates that the issues may be a good fit for community to help with. Requires work from eng. team and removed help wanted Up for grabs. We would accept a PR to help resolve this issue labels Oct 28, 2023
@ladeak
Copy link
Contributor

ladeak commented Oct 29, 2023

Is this still an open issue to be picked up? I see @MadL1me has addressed issues, or anything left to do here @wtgodbe ?

@wtgodbe
Copy link
Member Author

wtgodbe commented Oct 31, 2023

I don't think there's anything more to do here - @adityamandaleeka are there any other improvements the team wants to make in the tests at this point? From the original description of the issue, I believe the original intent was covered by #45541

@samsp-msft samsp-msft added the feature-rate-limit Work related to use of rate limit primitives label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-rate-limit Work related to use of rate limit primitives help candidate Indicates that the issues may be a good fit for community to help with. Requires work from eng. team
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
7 participants
@adityamandaleeka @ladeak @amcasey @wtgodbe @mkArtakMSFT @MadL1me @samsp-msft