Skip to content

Quarantine ClosingTheBrowserWindow_GracefullyDisconnects_TheCurrentCircuit #44185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dougbu opened this issue Sep 26, 2022 · 7 comments · Fixed by #54387
Closed

Quarantine ClosingTheBrowserWindow_GracefullyDisconnects_TheCurrentCircuit #44185

dougbu opened this issue Sep 26, 2022 · 7 comments · Fixed by #54387
Assignees
Labels
area-blazor Includes: Blazor, Razor Components blocked The work on this issue is blocked due to some dependency Pillar: Technical Debt Priority:0 Work that we can't release without test-failure
Milestone

Comments

@dougbu
Copy link
Member

dougbu commented Sep 26, 2022

Failing Test(s)

Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests.ClosingTheBrowserWindow_GracefullyDisconnects_TheCurrentCircuit()

This test has been passing only about 55% of the time over the last two weeks.

Error Message

Error message
Assert.True() Failure
Expected: True
Actual:   False

Stacktrace

   at Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests.CircuitGracefulTerminationTests.ClosingTheBrowserWindow_GracefullyDisconnects_TheCurrentCircuit() in /home/vsts/work/1/s/src/Components/test/E2ETest/ServerExecutionTests/CircuitGracefulTerminationTests.cs:line 71
--- End of stack trace from previous location ---

Logs

Microsoft.AspNetCore.Components.E2ETests.zip

Build

For example, build #20220923.29

@dougbu
Copy link
Member Author

dougbu commented Sep 26, 2022

/cc @dotnet/aspnet-blazor-eng

dougbu added a commit to dougbu/aspnetcore that referenced this issue Sep 26, 2022
…ts_TheCurrentCircuit`

- dotnet#44185
- also upload test logs for forks
@dougbu
Copy link
Member Author

dougbu commented Sep 26, 2022

Note #44186 will quarantine this test in the release/7.0 branch.

@TanayParikh TanayParikh added the area-blazor Includes: Blazor, Razor Components label Sep 26, 2022
dougbu added a commit that referenced this issue Sep 26, 2022
…ts_TheCurrentCircuit` (#44186)

- #44185
- also upload test logs for forks
@mkArtakMSFT mkArtakMSFT added this to the 8.0-MQ milestone Sep 28, 2022
captainsafia pushed a commit that referenced this issue Sep 29, 2022
…ts_TheCurrentCircuit` (#44186)

- #44185
- also upload test logs for forks
wtgodbe pushed a commit that referenced this issue Oct 4, 2022
…44227)

* [release/6.0] Add support for minimal APIs in ApiDescription.Server

* [release/7.0] Quarantine `ClosingTheBrowserWindow_GracefullyDisconnects_TheCurrentCircuit` (#44186)

- #44185
- also upload test logs for forks

* Update CircuitGracefulTerminationTests.cs

Co-authored-by: Doug Bunting <[email protected]>
@MackinnonBuck MackinnonBuck self-assigned this Oct 10, 2022
@MackinnonBuck
Copy link
Member

I've found that when running locally with headless mode disabled, this test succeeds consistently. It appears that the unload event is flaky in headless mode specifically, causing the _blazor/disconnect request to never get sent, resulting in the test failure.

There is also the question of how much value this test is really adding - especially in non-desktop scenarios, the unload event is highly unreliable, so graceful termination of the circuit on tab/window close is more of an exception than the rule.

@MackinnonBuck
Copy link
Member

We should address this after we implement #39409.

@MackinnonBuck MackinnonBuck modified the milestones: 8.0-MQ, .NET 8 Planning Nov 2, 2022
@ghost
Copy link

ghost commented Nov 2, 2022

Thanks for contacting us.

We're moving this issue to the .NET 8 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@ghost
Copy link

ghost commented Oct 6, 2023

Thanks for contacting us.

We're moving this issue to the .NET 9 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@ghost
Copy link

ghost commented Dec 14, 2023

Thanks for contacting us.

We're moving this issue to the .NET 9 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components blocked The work on this issue is blocked due to some dependency Pillar: Technical Debt Priority:0 Work that we can't release without test-failure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants