-
Notifications
You must be signed in to change notification settings - Fork 12.4k
We need a solution for API Explorer + Custom ModelBinder #4825
Copy link
Copy link
Open
Labels
Needs: DesignThis issue requires design work before implementating.This issue requires design work before implementating.affected-fewThis issue impacts only small number of customersThis issue impacts only small number of customersarea-mvcIncludes: MVC, Actions and Controllers, Localization, CORS, most templatesIncludes: MVC, Actions and Controllers, Localization, CORS, most templatesenhancementThis issue represents an ask for new feature or an enhancement to an existing oneThis issue represents an ask for new feature or an enhancement to an existing onefeature-openapiseverity-majorThis label is used by an internal toolThis label is used by an internal tool
Milestone
Description
Activity
Metadata
Metadata
Assignees
Labels
Needs: DesignThis issue requires design work before implementating.This issue requires design work before implementating.affected-fewThis issue impacts only small number of customersThis issue impacts only small number of customersarea-mvcIncludes: MVC, Actions and Controllers, Localization, CORS, most templatesIncludes: MVC, Actions and Controllers, Localization, CORS, most templatesenhancementThis issue represents an ask for new feature or an enhancement to an existing oneThis issue represents an ask for new feature or an enhancement to an existing onefeature-openapiseverity-majorThis label is used by an internal toolThis label is used by an internal tool
Type
Projects
- StatusShow more project fieldsNo status
see: aspnet/Mvc#5673 (comment) and domaindrivendev/Swashbuckle.AspNetCore#309
The complaint here is that we 'expand' a parameter in the API definition that's being bound by a custom model binder. API explorer has no interaction with model binders/providers, and so no way to know that this isn't being handled by the default binder.
In this case we already have a metadata feature that would give the desired API explorer output,
ModelMetadata.IsComplexType == false. However we don't allow user code to configure this value.We should either make this configurable, or probe the model binders for information about types that have custom handling.