Skip to content

Flesh out the GetProjectReferenceMetadata task #4912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dougbu opened this issue Sep 7, 2018 · 2 comments
Closed

Flesh out the GetProjectReferenceMetadata task #4912

dougbu opened this issue Sep 7, 2018 · 2 comments
Assignees
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one

Comments

@dougbu
Copy link
Contributor

dougbu commented Sep 7, 2018

Is this a Bug or Feature request?

Enhancement that's part of #4896

Description of the problem

The current GetProjectReferenceMetadata task is basically a stub. It needs to get the requisite metadata and add it to the Inputs items i.e. behave like GetFileReferenceMetadata and GetUriReferenceMetadata but with ServiceProjectReference items. See expected metadata in the <ItemDefinitionGroup/> at https://github.com/aspnet/Mvc/blob/364b3a7720cb6f925b0eea39ef8e7e8df47af57d/src/Microsoft.Extensions.ApiDescription.Client/build/Microsoft.Extensions.ApiDescription.Client.props#L59-L104

Of course, also need to use this task in Microsoft.Extensions.ApiDescription.Client.targets and thereby simplify the ServiceProjectReferenceGenerator target.

This issue will not remove the need for the GetDocumentInsider to retrieve information from the web site project prior to doing its work. Most metadata the inside man needs e.g. a default %(Uri) is not generic enough to be of interest in other document generators.

Version of Microsoft.AspNetCore.Mvc or Microsoft.AspNetCore.App or Microsoft.AspNetCore.All

See the features/client.code.generation branch branch. That work is intended for the 2.2 Preview 3 milestone.

@dougbu dougbu self-assigned this Sep 7, 2018
@aspnet-hello aspnet-hello transferred this issue from aspnet/Mvc Dec 14, 2018
@aspnet-hello aspnet-hello assigned dougbu and unassigned dougbu Dec 14, 2018
@aspnet-hello aspnet-hello added this to the ClientCodeGen milestone Dec 14, 2018
@aspnet-hello aspnet-hello added 1 - Ready area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one labels Dec 14, 2018
@mkArtakMSFT mkArtakMSFT modified the milestones: ClientCodeGen, 3.0.0-preview3, 3.0.0-preview4 Feb 6, 2019
@dougbu
Copy link
Contributor Author

dougbu commented Apr 18, 2019

Oops, realized this will complete when my draft PR for #8242 (expected tonight or tomorrow). Moving to same milestone as that issue. I continue to work on both issues.

@dougbu dougbu modified the milestones: 3.0.0-preview5, 3.0.0-preview6 Apr 18, 2019
@mkArtakMSFT mkArtakMSFT modified the milestones: 3.0.0-preview6, Backlog Apr 19, 2019
@mkArtakMSFT mkArtakMSFT modified the milestones: Backlog, 3.0.0-preview6 May 30, 2019
dougbu added a commit that referenced this issue Jun 4, 2019
…0669)

- #8242 2 of 2, # #4912
- add missing project reference provider
  - remove incorrect `$(IsImplementationProject)` settings in `dotnet-getdocument` and `GetDocumentInsider`
  - re-run .\eng\scripts\GenerateProjectList.ps1
@dougbu
Copy link
Contributor Author

dougbu commented Jun 4, 2019

Removed this task entirely when creating the Microsoft.Extensions.ApiDescription.Server package (b3ddd65) and rewriting the GetDocumentInsider tool (4c8ca0b). Cleanup is done.

@dougbu dougbu closed this as completed Jun 4, 2019
@dougbu dougbu added Done This issue has been fixed and removed Working labels Jun 4, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one
Projects
None yet
Development

No branches or pull requests

3 participants