Skip to content

BlazorWasmHosted build benchmark broken #49760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sebastienros opened this issue Jul 31, 2023 · 5 comments · Fixed by aspnet/Benchmarks#1943
Closed

BlazorWasmHosted build benchmark broken #49760

sebastienros opened this issue Jul 31, 2023 · 5 comments · Fixed by aspnet/Benchmarks#1943
Assignees
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Perf Pillar: Technical Debt Priority:0 Work that we can't release without
Milestone

Comments

@sebastienros
Copy link
Member

This project was broken when the latest changes on the templates were merged.
https://github.com/aspnet/Benchmarks/blob/main/src/BenchmarksApps/BuildPerformance/README.md

[STDERR] Unhandled exception: System.ComponentModel.Win32Exception (267): An error occurred trying to start process 'C:\Users\Administrator\AppData\Local\Temp\benchmarks-agent\benchmarks-server-9136\qq44uvvy.wwq\dotnet.exe' with working directory 'C:\Users\Administrator\AppData\Local\Temp\benchmarks-agent\benchmarks-server-9136\wcawhtmj.kei\src\BenchmarksApps\BuildPerformance\published\hbayyqmi.rmx\Server'. The directory name is invalid.
[STDERR]    at System.Diagnostics.Process.StartWithCreateProcess(ProcessStartInfo startInfo)
[STDERR]    at System.Diagnostics.Process.Start(ProcessStartInfo startInfo)
[STDERR]    at Build.DotNet.ExecuteAsync(String args, String workingDir) in C:\Users\Administrator\AppData\Local\Temp\benchmarks-agent\benchmarks-server-9136\wcawhtmj.kei\src\BenchmarksApps\BuildPerformance\Dotnet.cs:line 49
[STDERR]    at Build.BlazorWasmHosted.Build() in C:\Users\Administrator\AppData\Local\Temp\benchmarks-agent\benchmarks-server-9136\wcawhtmj.kei\src\BenchmarksApps\BuildPerformance\BlazorWasmHosted.cs:line 49
[STDERR]    at Build.BlazorWasmHosted.RunAsync() in C:\Users\Administrator\AppData\Local\Temp\benchmarks-agent\benchmarks-server-9136\wcawhtmj.kei\src\BenchmarksApps\BuildPerformance\BlazorWasmHosted.cs:line 32

For now I am disabling these benchmarks.

@sebastienros sebastienros added Perf area-blazor Includes: Blazor, Razor Components labels Jul 31, 2023
@sebastienros
Copy link
Member Author

The BlazorServer benchmark is also broken

MSBuild version 17.8.0-preview-23401-01+b3989dc43 for .NET
  Determining projects to restore...
  All projects are up-to-date for restore.
/tmp/benchmarks-agent/benchmarks-server-1/pzz5a0cn.rkw/sdk/8.0.100-rc.1.23401.24/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.RuntimeIdentifierInference.targets(311,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [/tmp/benchmarks-agent/benchmarks-server-1/0fqvhi5r.liy/src/BenchmarksApps/BuildPerformance/published/gsnni0cf.1gn/gsnni0cf.1gn.csproj]
/tmp/benchmarks-agent/benchmarks-server-1/0fqvhi5r.liy/src/BenchmarksApps/BuildPerformance/published/gsnni0cf.1gn/_Imports.razor(9,21): error CS0234: The type or namespace name 'Shared' does not exist in the namespace 'gsnni0cf._1gn' (are you missing an assembly reference?) [/tmp/benchmarks-agent/benchmarks-server-1/0fqvhi5r.liy/src/BenchmarksApps/BuildPerformance/published/gsnni0cf.1gn/gsnni0cf.1gn.csproj]
/tmp/benchmarks-agent/benchmarks-server-1/0fqvhi5r.liy/src/BenchmarksApps/BuildPerformance/published/gsnni0cf.1gn/_Imports.razor(9,21): error CS0234: The type or namespace name 'Shared' does not exist in the namespace 'gsnni0cf._1gn' (are you missing an assembly reference?) [/tmp/benchmarks-agent/benchmarks-server-1/0fqvhi5r.liy/src/BenchmarksApps/BuildPerformance/published/gsnni0cf.1gn/gsnni0cf.1gn.csproj]
/tmp/benchmarks-agent/benchmarks-server-1/0fqvhi5r.liy/src/BenchmarksApps/BuildPerformance/published/gsnni0cf.1gn/_Imports.razor(9,21): error CS0234: The type or namespace name 'Shared' does not exist in the namespace 'gsnni0cf._1gn' (are you missing an assembly reference?) [/tmp/benchmarks-agent/benchmarks-server-1/0fqvhi5r.liy/src/BenchmarksApps/BuildPerformance/published/gsnni0cf.1gn/gsnni0cf.1gn.csproj]
/tmp/benchmarks-agent/benchmarks-server-1/0fqvhi5r.liy/src/BenchmarksApps/BuildPerformance/published/gsnni0cf.1gn/_Imports.razor(9,21): error CS0234: The type or namespace name 'Shared' does not exist in the namespace 'gsnni0cf._1gn' (are you missing an assembly reference?) [/tmp/benchmarks-agent/benchmarks-server-1/0fqvhi5r.liy/src/BenchmarksApps/BuildPerformance/published/gsnni0cf.1gn/gsnni0cf.1gn.csproj]
/tmp/benchmarks-agent/benchmarks-server-1/0fqvhi5r.liy/src/BenchmarksApps/BuildPerformance/published/gsnni0cf.1gn/_Imports.razor(9,21): error CS0234: The type or namespace name 'Shared' does not exist in the namespace 'gsnni0cf._1gn' (are you missing an assembly reference?) [/tmp/benchmarks-agent/benchmarks-server-1/0fqvhi5r.liy/src/BenchmarksApps/BuildPerformance/published/gsnni0cf.1gn/gsnni0cf.1gn.csproj]
/tmp/benchmarks-agent/benchmarks-server-1/0fqvhi5r.liy/src/BenchmarksApps/BuildPerformance/published/gsnni0cf.1gn/_Imports.razor(9,21): error CS0234: The type or namespace name 'Shared' does not exist in the namespace 'gsnni0cf._1gn' (are you missing an assembly reference?) [/tmp/benchmarks-agent/benchmarks-server-1/0fqvhi5r.liy/src/BenchmarksApps/BuildPerformance/published/gsnni0cf.1gn/gsnni0cf.1gn.csproj]
/tmp/benchmarks-agent/benchmarks-server-1/0fqvhi5r.liy/src/BenchmarksApps/BuildPerformance/published/gsnni0cf.1gn/_Imports.razor(9,21): error CS0234: The type or namespace name 'Shared' does not exist in the namespace 'gsnni0cf._1gn' (are you missing an assembly reference?) [/tmp/benchmarks-agent/benchmarks-server-1/0fqvhi5r.liy/src/BenchmarksApps/BuildPerformance/published/gsnni0cf.1gn/gsnni0cf.1gn.csproj]

Build FAILED.

@mkArtakMSFT mkArtakMSFT added the bug This issue describes a behavior which is not expected - a bug. label Aug 7, 2023
@mkArtakMSFT mkArtakMSFT added this to the .NET 9 Planning milestone Aug 7, 2023
@mkArtakMSFT
Copy link
Contributor

These got broke because we've removed the Blazor Server and Blazor WebAssembly Hosted templates.
We will consider to fix these tests utilizing the new Blazor Web App project template, where it uses either client or server interactivity to cover both broken scenarios.

@sebastienros
Copy link
Member Author

These benchmarks have allowed us to catch two regressions on the build/assets pipeline in the sdk this summer, it makes me sad they are not running anymore.

Note for myself, we need to restore the continuous runs once this is fixed

@ghost
Copy link

ghost commented Dec 18, 2023

Thanks for contacting us.

We're moving this issue to the .NET 9 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@sebastienros
Copy link
Member Author

Current error messages since we moved back to 9.0 continuous runs:

[STDERR] --use-wasm
[STDERR]    '--use-wasm' is not a valid option

and

[STDERR] --use-server
[STDERR]    '--use-server' is not a valid option

@lewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Perf Pillar: Technical Debt Priority:0 Work that we can't release without
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants