Fix Blazor WebAssembly Hosted and Blazor Server build perf benchmarks #1943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MackinnonBuck
commented
Feb 6, 2024
| @@ -117,20 +114,5 @@ async Task AddParameterToComponent() | |||
| buildDuration.TotalMilliseconds, | |||
| "Add a parameter to .razor"); | |||
| } | |||
|
|
|||
| async Task ModifyCshtmlFile() | |||
There was a problem hiding this comment.
Removed this because there are no .cshtml files in the template anymore.
| @@ -67,23 +66,9 @@ async Task ChangeServer() | |||
| "Change a file in Server"); | |||
| } | |||
|
|
|||
| async Task ChangeShared() | |||
There was a problem hiding this comment.
Removed this because there is no "Shared" project anymore.
|
Verified with this command |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Blazor WebAssembly Hosted and Blazor Server build perf benchmarks
Updates these two benchmarks to account for changes to the project templates in .NET 8.
It should be noted that the "Blazor WebAssembly Hosted" and "Blazor Server" templates don't actually exist anymore - they're now just variants of the "Blazor Web App" template. That said, I haven't changed any test names, etc. in this PR in case that breaks continuity in the dashboards. I will probably perform the rename as part of dotnet/aspnetcore#51971.
Fixes dotnet/aspnetcore#49760