DOM sync removes checkbox custom values in some cases #50995
Assignees
Labels
area-blazor
Includes: Blazor, Razor Components
bug
This issue describes a behavior which is not expected - a bug.
Milestone
Comments
mkArtakMSFT
added
the
bug
mkArtakMSFT
pushed a commit
that referenced
this issue
Sep 28, 2023
# Fix checkbox DOM sync Unbreaks checkboxes with custom value attributes. ## Description There was a trivial logic error in the DOM syncing code, causing the `value` attribute on checkboxes to get wrongly overwritten in a certain case (if there was a custom value attribute and `checked` was unchanged). Fixes #50995 ## Customer Impact In some cases, checkbox values would get corrupted after an enhanced navigation. This would break form functionality. The specific scenario was "checkboxes with a custom value attribute, when an enhanced nav leaves the `checked` state unchanged". ## Regression? - [ ] Yes - [x] No [If yes, specify the version the behavior has regressed from] ## Risk - [ ] High - [ ] Medium - [x] Low Very low because it's a tiny code edit, and only affects a very specific scenario, and the old logic was (in retrospect) definitely incorrect. ## Verification - [x] Manual (required) - [x] Automated ## Packaging changes reviewed? - [ ] Yes - [ ] No - [x] N/A
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Repro:
<input type="checkbox" value="myvalue" checked>If you do an enhanced nav and the resulting content also contains that exact same markup, the
valueattribute will get overwritten with the stringtrue. Then when you submit the form you'll get wrong results.I tracked this down to a trivial logic error in the DOM sync code - fix submitted in #50991
The text was updated successfully, but these errors were encountered: