Skip to content

[Infrastructure] get-version fails on our CI because node is not installed by the CI pipeline. #53091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javiercn opened this issue Jan 2, 2024 · 2 comments
Assignees
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Comments

@javiercn
Copy link
Member

javiercn commented Jan 2, 2024

https://dev.azure.com/dnceng/internal/_build/results?buildId=2341287&view=results

The issue is that nodejs is not installed, so when we run npm run get-version, the command fails. We need to make sure that node is installed and npm ci is run or find an alternative way to collect the package versions for npm packages.

We can either do this in node, or get all the package.json files in the build and read them to get the version.

As a workaround, we simply flow the version from the build system as in e6be3e9 which is ok because we aren't producing individual versions for our packages, but it risks not being correct now or in the future.

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 2, 2024
@wtgodbe
Copy link
Member

wtgodbe commented Jan 3, 2024

Is there a reason we need to get the npm package versions other than using it in /eng/publishing.props? Because if it's the latter, we can just choose a different project - originally the choice of an .npmproj was somewhat arbitrary.

@wtgodbe
Copy link
Member

wtgodbe commented Jan 9, 2024

Done by #53209

@wtgodbe wtgodbe closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

No branches or pull requests

2 participants