[Blazor] Remove checked-in JS files #53209
Conversation
ghost
added
the
| @@ -4,6 +4,7 @@ | |||
| <Import Project="$(MSBuildThisFileDirectory)..\Directory.Build.props" /> | |||
|
|
|||
| <PropertyGroup> | |||
| <ExcludeFromSourceBuild>false</ExcludeFromSourceBuild> | |||
There was a problem hiding this comment.
Was this being defaulted to true for this project?
There was a problem hiding this comment.
Yes, I think we need to fix this "long term" so that we don't have to do anything special inside SourceBuild.props
| @@ -14,7 +14,7 @@ parameters: | |||
| # This is the default platform provided by Arcade, intended for use by a managed-only repo. | |||
| defaultManagedPlatform: | |||
| name: 'Managed' | |||
| container: 'mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream8' | |||
| container: 'mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream8-20240104210103-4893224' | |||
There was a problem hiding this comment.
Do we use the non-suffixed centos-stream8 container without this? Anything we check in to an eng/common/* file will get overwritten by the next arcade update - but my understanding was that the container we specify in ci.yml for SourceBuild should be the one that gets used, which would make this change unnecessary
There was a problem hiding this comment.
Ah, didn't know about it. I think mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream8 already contains what we need, I just used the tagged version and did a find and replace everywhere. If this gets overridden in the next arcade update, that's ok
* Always install node in CI * Update ci.yml Enable building nodejs * Update to Alpine 3.17 * Update .azure/pipelines/ci.yml Try with 3.15-local * Update .azure/pipelines/ci.yml Remove local suffix * Update .azure/pipelines/ci.yml Go back to 3.17 * Update ci.yml * [Blazor] Remove checked-in JS files (#53209) * [Blazor] Remove checked-in JS files * Update .gitignore and fix paths * Update images to Centos8 * Update ubuntu images * Make sure NPM scripts build inside sourcebuild * Disable running Firefox on Mac OS --------- Co-authored-by: Javier Calvarro Nelson <[email protected]>
#11592