Show errors in the log from VerifyUserTokenAsync

[LindaLawton]

I am getting a nice warning in my logs when the code is invalid from L1712

warn: Microsoft.AspNetCore.Identity.UserManager[9]
VerifyUserTokenAsync() failed with purpose: ResetPassword for user 21248592.

However it does not tell me what the error is in the error message is. I have had to add this in my own code.

dbug:IdentityServer.Controllers.Account.AccountController[2150]
User invite failed for [User: 21248592] [error: Invalid token.]

Which basically means i have two log entries for the same issue. It would be nice to get a list of the errors from the result into the warning message.

Can i suggest something like this? I would be happy to submit a pull request if you like

if (!result)
            {
               var errors = string.Join(", ", result.Errors.Select(a => a.Description));
                Logger.LogWarning(9, "VerifyUserTokenAsync() failed with purpose: {purpose} for user {userId}. 
 Errors {errors }", purpose, await GetUserIdAsync(user), errors );
            }

[blowdart]

Sure, a PR would be lovely thank you.

[LindaLawton]

I haven't forgotten this you can expect something Friday

[LindaLawton]

Ok now i am curious. Why is DataProtectorTokenProvider ValidateAsync returning false for all the errors? Why not return the actual error to the developer so we can at least debug why its invalid.

Ok i agree that a validate method would just return true or false. but Logs maybe?

[guylando]

+1 DataProtectorTokenProvider ValidateAsync just returning false without logs makes it much harder to understand what is the problem because of the lack of logs (debug level logs seem appropriate)

[dpr-dev]

Hello, can I create PR for this issue ?

@HaoK, @blowdart

[HaoK]

sure go ahead