DefaultHttpResponse.StartAsync without feature

[JamesNK]

If there is no IHttpResponseStartFeature then StartAsync will call Body.FlushAsync every time. Should it only call Body.FlushAsync if HasStarted is false?

https://github.com/aspnet/AspNetCore/blob/25f1f593783de4819a1e8e30dc09af7388cc68b3/src/Http/Http/src/Internal/DefaultHttpResponse.cs#L147-L155

[jkotalik]

Yeah I'd be fine with that change.

[jkotalik]

Going to put this in preview3 for now (it's a 1 line fix). @muratg are we still fine to merge into preview3 or does it require approval?

[muratg]

@jkotalik would require approval. cc @Eilon

[Eilon]

Why do we need it in preview3? What doesn't work that would affect a customer trying preview3?

[jkotalik]

We don’t need it, I didn’t know what the new cut line was. We can do this in preview 4 no problem. Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Eilon Lipton <notifications@github.com> Sent: Thursday, February 21, 2019 9:40:03 AM To: aspnet/AspNetCore Cc: Justin Kotalik; Mention Subject: Re: [aspnet/AspNetCore] DefaultHttpResponse.StartAsync without feature (#7778) Why do we need it in preview3? What doesn't work that would affect a customer trying preview3? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faspnet%2FAspNetCore%2Fissues%2F7778%23issuecomment-466093944&data=02%7C01%7CJustin.Kotalik%40microsoft.com%7C50d1c0607c904226cc2708d698239c90%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636863676053043847&sdata=Y0vdm%2BkoY76wxPqgWvl7HdtH14D%2FxNVn%2Fnt%2Bh1DjpZU%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAH6uFWree_KubSHprL5gZotcYaKe0vSxks5vPtnzgaJpZM4bGY7w&data=02%7C01%7CJustin.Kotalik%40microsoft.com%7C50d1c0607c904226cc2708d698239c90%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636863676053043847&sdata=05BuHs45kGaSeAvPqWD%2Bg%2B5XelRkCL9AQFGDuQ0JZWs%3D&reserved=0>.

[Eilon]

If it's not a critical need or preview 3 then I wouldn't bother and just go with master.

[jkotalik]

We decided to keep the flush behavior, but we should still check IsStarted too.