Disable test reporting for flaky tests on Helix #10352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotalik
approved these changes
May 17, 2019
Eilon
added
the
area-infrastructure
|
aspnet/AspNetCore-Internal#2482 will likely take some feature work to resolve so I think we probably want to merge this and make the helix test check marks more meaningful. @natemcmaster @dougbu . Note that even this test run isn't green but that's because there are flaky tests that haven't been marked as such. |
Let's apply |
natemcmaster
approved these changes
May 21, 2019
|
Yup @ @alexperovich is looking into devops features and workarounds. |
|
Seems like I mis-spoke the helix test failures are not flakiness, they are consistently failing. Will file followup issues. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I look into https://github.com/aspnet/AspNetCore-Internal/issues/2482. We might want to disable test reporting of flaky Helix tests so the PR checks are more meaningful.
WIP don't review yet.