Fix more null refs in Api Analyzers #10375

pranavkm · 2019-05-19T04:56:35Z

Make attributes used by analyzer public
Compile analyzer tests against ref assemblies
Turn on Nullable reference types and harden some null-checks

* Make attributes used by analyzer public * Compile analyzer tests against ref assemblies * Turn on Nullable reference types and harden some null-checks

src/Mvc/Mvc.Analyzers/src/Microsoft.AspNetCore.Mvc.Analyzers.csproj

src/Mvc/Mvc.Analyzers/src/TopLevelParameterNameAnalyzer.cs

src/Mvc/Mvc.Analyzers/test/Mvc.Analyzers.Test.csproj

src/Mvc/Mvc.Api.Analyzers/src/ActualApiResponseMetadata.cs

src/Mvc/Mvc.Core/src/Infrastructure/ActionResultStatusCodeAttribute.cs

src/Mvc/Mvc.Core/src/Infrastructure/ActionResultObjectValueAttribute.cs

pranavkm

🆙 📅

rynowak · 2019-05-21T20:27:13Z

src/Mvc/Mvc.Analyzers/src/TopLevelParameterNameAnalyzer.cs

+                    return false;
+                }
+
+


Why is aquaman sad?

Thanos collected the one ring and now aquaman has to leave Hogwarts. Poor aquaman 😢

I'll clean up the extra new lines in a follow up.

rynowak · 2019-05-21T20:27:16Z

src/Mvc/Mvc.Analyzers/src/TopLevelParameterNameAnalyzer.cs

+                    return false;
+                }
+
+


rynowak · 2019-05-21T20:28:46Z

src/Mvc/Mvc.Api.Analyzers/src/AddResponseTypeAttributeCodeFixAction.cs

+                return _document;
+            }
+
+            var context = nullableContext.Value;


FYI this shouldn't be needed. The flow analysis should do the right thing after it sees the null check at L48.

Example: https://github.com/aspnet/AspNetCore/pull/10375/files#diff-51adbcdc12291a2342784a001a9f502bR57

error CS1061: 'AddResponseTypeAttributeCodeFixAction.CodeActionContext?' does not contain a definition for 'SymbolCache' and no accessible extension method 'SymbolCache' accepting a first argument of type 'AddResponseTypeAttributeCodeFixAction.CodeActionContext?' could be found

Doesn't seem to work if I remove it. Perhaps because it's a value type.

Fix more null refs in Api Analyzers

d951a5c

* Make attributes used by analyzer public * Compile analyzer tests against ref assemblies * Turn on Nullable reference types and harden some null-checks

Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label May 20, 2019