More docker resiliency for tests #10425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
requested review from
analogrelay,
halter73 and
mikaelm12
as code owners
analogrelay
reviewed
May 21, 2019
| Thread.Sleep(1000); | ||
|
|
||
| // Call stop just in case the container somehow started after the timeout so our retry logic doesn't fail | ||
| RunProcessAndWait(_path, $"stop {_dockerContainerName}", "docker stop", logger, TimeSpan.FromSeconds(15), out var _); |
Contributor
There was a problem hiding this comment.
Will this throw if the container is already stopped?
Member
Author
There was a problem hiding this comment.
Nope, that would be RunProcessAndThrowIfFailed
Member
Author
|
Ping |
analogrelay
approved these changes
May 23, 2019
Member
Author
|
This comment was made automatically. If there is a problem contact aspnetcore-build@microsoft.com. I've triaged the above build. I've created/commented on the following issue(s) |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably fixes https://github.com/aspnet/AspNetCore-Internal/issues/2502