Add <frameworkReferences> metadata to nuspec of packages that depend on the shared framework #10429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemcmaster
added
the
feature-platform
JunTaoLuo
approved these changes
May 21, 2019
natemcmaster
changed the title
dougbu
reviewed
May 22, 2019
| new XElement(ns + "frameworkReferences", | ||
| new XElement(ns + "group", | ||
| new XAttribute("targetFramework", NuGetFramework.Parse(SharedFrameworkTargetFramework).GetFrameworkString()), | ||
| new XElement(ns + "frameworkReference", new XAttribute("name", "Microsoft.AspNetCore.App"))))); |
There was a problem hiding this comment.
Surprised the package builder can't be used here. Would be nice to avoid reaching down into the XML.
Is there an issue open somewhere in the NuGet world on this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #4257. This hacks the
<frameworkReference>metadata into packages which depend on a framework-only assembly because we can't update our build to use<FrameworkReference>in .csproj just yet.This is part of resolving https://github.com/dotnet/cli/issues/10666.
Expected output: any package which depends on Microsoft.AspNetCore.App should have this in its nuspec: