-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Fix TLS protocols used in tests #10483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is actually a bit concerning, these tests aren't doing anything that should be OS specific. The only difference I see is that they specify SslProtocols.None rather than SslProtocols.Tls11 | SslProtocols.Tls12. Win7 defaults topped out at TLS 1.0. https://support.microsoft.com/en-us/help/3154520/support-for-tls-system-default-versions-included-in-the-net-framework. Kestrel defaults to 1.1 & 1.2 so this may explain the conflict. Try changing the test to SslProtocols.Tls11 | SslProtocols.Tls12 instead. |
src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpsTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This matches the default value for SslProtocols in HttpsConnectionAdapterOptions, so it makes sense.
I updated the PR to close https://github.com/aspnet/AspNetCore-Internal/issues/2490 when merged since we believe it will solve the issue. |
Looks like the test is fixed! Thanks @Tratcher. |
This comment was made automatically. If there is a problem contact [email protected]. I've triaged the above build. I've created/commented on the following issue(s) |
Fixes https://github.com/aspnet/AspNetCore-Internal/issues/2490
Disabling tests failing in https://github.com/aspnet/AspNetCore-Internal/issues/2490.