Skip to content

Fix TLS protocols used in tests #10483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2019
Merged

Fix TLS protocols used in tests #10483

merged 3 commits into from
May 24, 2019

Conversation

JunTaoLuo
Copy link
Contributor

@JunTaoLuo JunTaoLuo commented May 23, 2019

@Eilon Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 23, 2019
@Tratcher
Copy link
Member

This is actually a bit concerning, these tests aren't doing anything that should be OS specific.

The only difference I see is that they specify SslProtocols.None rather than SslProtocols.Tls11 | SslProtocols.Tls12.

Win7 defaults topped out at TLS 1.0. https://support.microsoft.com/en-us/help/3154520/support-for-tls-system-default-versions-included-in-the-net-framework. Kestrel defaults to 1.1 & 1.2 so this may explain the conflict.
https://github.com/aspnet/AspNetCore/blob/c2e2d7d1359ef8caf5460562adfe46b7f4f68df0/src/Servers/Kestrel/Core/src/HttpsConnectionAdapterOptions.cs#L27

Try changing the test to SslProtocols.Tls11 | SslProtocols.Tls12 instead.

@analogrelay analogrelay requested a review from halter73 May 23, 2019 21:47
@halter73 halter73 changed the title Skip failing helix tests Fix failing helix tests May 23, 2019
Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This matches the default value for SslProtocols in HttpsConnectionAdapterOptions, so it makes sense.

@natemcmaster natemcmaster changed the title Fix failing helix tests Fix TLS protocols used in tests May 23, 2019
@analogrelay
Copy link
Contributor

I updated the PR to close https://github.com/aspnet/AspNetCore-Internal/issues/2490 when merged since we believe it will solve the issue.

@JunTaoLuo
Copy link
Contributor Author

Looks like the test is fixed! Thanks @Tratcher.

@JunTaoLuo
Copy link
Contributor Author

@aspnet-hello
Copy link

This comment was made automatically. If there is a problem contact [email protected].

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2570

@JunTaoLuo JunTaoLuo merged commit 2c70498 into master May 24, 2019
@JunTaoLuo JunTaoLuo deleted the johluo/skip-helix-tests branch May 24, 2019 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants