Add missing symbols for our packages #10539
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotalik
reviewed
May 25, 2019
| @@ -10,7 +10,6 @@ | |||
| <PackageType>AzureSiteExtension</PackageType> | |||
| <NoPackageAnalysis>true</NoPackageAnalysis> | |||
| <IncludeBuildOutput>false</IncludeBuildOutput> | |||
| <IncludeSymbols>false</IncludeSymbols> | |||
There was a problem hiding this comment.
I'm not sure if this is the right approach. There isn't any code in this package (see https://github.com/aspnet/AspNetCore/tree/master/src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension). What error are you hitting with this package?
There was a problem hiding this comment.
This is one of the few packages containing Microsoft.Web.Xdt.Extensions.dll. How else would you suggest we get its .pdb deployed?
There was a problem hiding this comment.
Maybe I missed it, but I looked at the artifacts in this PR and didn't see Microsoft.Web.Xdt.Extensions.pdb.
Eilon
added
the
area-infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See second attempt of https://dnceng.visualstudio.com/internal/_releaseProgress?_a=release-pipeline-progress&releaseId=8097 for validation of the symbol packages