Skip to content

Produce Microsoft.AspNetCore.Authorization as a package #10684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 31, 2019
Merged

Produce Microsoft.AspNetCore.Authorization as a package #10684

merged 4 commits into from
May 31, 2019

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented May 31, 2019 •
edited
Loading

This is required for client-side blazor, as Microsoft.AspNetCore.Components references is a package in the Blazor client-side case.

@javiercn
Produce Microsoft.AspNetCore.Authorization as a package
7f10e27 
This is needed for Blazor (client-side)
@javiercn javiercn requested a review from a team as a code owner May 31, 2019 07:15
@javiercn javiercn requested a review from rynowak May 31, 2019 07:28
@javiercn javiercn mentioned this pull request May 31, 2019
Closed
@JunTaoLuo
Copy link
Contributor

Might want to check the steps here: https://github.com/aspnet/AspNetCore/blob/master/docs/ReferenceAssemblies.md. Note the section on adding a new project.

@javiercn
Copy link
Member Author

@JunTaoLuo Thanks and... why aren't you asleep? 😄

@JunTaoLuo
Copy link
Contributor

Could also consult #10669 as a reference.

@javiercn
Copy link
Member Author

I was in the process of running eng\generateprojectreferences and it produced nothing BTW

@JunTaoLuo
Copy link
Contributor

Hehe, I sleep at odd hours. I'll do a more thorough check in the morning but have you tried running .\eng\scripts\GenerateProjectList.ps1? I'm not sure what eng\generateprojectreferences is.

@javiercn
Copy link
Member Author

Yeah, I think I got it figured out.

@javiercn
Copy link
Member Author

/Azure-pipelines run

1 similar comment
@javiercn
Copy link
Member Author

/Azure-pipelines run

@javiercn
Copy link
Member Author

/Azure-pipelines run

@javiercn
Copy link
Member Author

@aspnet/build I am not able to get this PR to run the required checks

@dougbu
Copy link
Contributor

dougbu commented May 31, 2019

I am not able to get this PR to run the required checks

It's not only your PR and it's not only this repo e.g. https://github.com/aspnet/EntityFrameworkCore/pull/15878/checks?check_run_id=139437341. It appears to be GitHub flakiness but I'm not sure.

@mkArtakMSFT mkArtakMSFT added the area-blazor Includes: Blazor, Razor Components label May 31, 2019
@JunTaoLuo
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@JunTaoLuo
Copy link
Contributor

Hmm I expect eng/ProjectReferences.props to be updated after you run ./eng/scripts/GenerateProjectList.ps1 but I don't see that in the list of files changed.

@javiercn
Copy link
Member Author

I ran both, but I'm gonna give it another try

natemcmaster
natemcmaster approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@natemcmaster natemcmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@javiercn
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s), but failed to run 1 pipeline(s).

JunTaoLuo
JunTaoLuo approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@JunTaoLuo JunTaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, we're just making them as shiping now. Makes sense.

@javiercn javiercn merged commit 3f041ce into master May 31, 2019
@ghost ghost deleted the javiercn/authorization-package branch May 31, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

@natemcmaster natemcmaster natemcmaster approved these changes

@rynowak rynowak Awaiting requested review from rynowak

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@javiercn @JunTaoLuo @dougbu @natemcmaster @mkArtakMSFT