Add unmatched attributes support to forms #10712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deleted the
I didn't see the other issue but my opinions are:
Yes
Yes |
| builder.AddAttribute(3, "id", Id); | ||
| builder.AddAttribute(4, "class", CssClass); | ||
| builder.AddAttribute(5, "checked", BindMethods.GetValue(CurrentValue)); | ||
| builder.AddAttribute(6, "onchange", BindMethods.SetValueHandler(__value => CurrentValue = __value, CurrentValue)); |
There was a problem hiding this comment.
At some point, we should think about somehow combining any explicitly-provided onchange with the one that bind is using (e.g., calling theirs from ours).
|
This is such a big improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5071
This change makes it possible to use attributes that aren't directly supported by our components.
Ex:
placeholderisn't something we define or handle insideInputText- it just gets passed through to the underlying input element.This support is limited to components implemented in C# for now, and we'll be doing a language feature to light it up for components written in Razor in preview 7 (see #5071)
I'm logging a separate issue to follow up on two things I didn't address in this PR because I think they need a discussion.
IdandClassfrom these components now that we support pass throughNavLinkto use this feature