Skip to content

Simplify web project templates #10347 #10808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 5, 2019
Merged

Simplify web project templates #10347 #10808

merged 3 commits into from
Jun 5, 2019

Conversation

isaacrlevin
Copy link
Contributor

Summary of the changes

  • Remove CDNs from all Web Projects
  • Remove environment tags from templates

Addresses #10347

@isaacrlevin
Copy link
Contributor Author

Let me know if you want me to remove CDN tests here

https://github.com/aspnet/AspNetCore/blob/master/src/ProjectTemplates/test/CdnScriptTagTests.cs

ryanbrandenburg
ryanbrandenburg approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@ryanbrandenburg ryanbrandenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're good to go once you remove the CDN tests.

....ProjectTemplates/content/RazorPagesWeb-CSharp/Pages/Shared/_ValidationScriptsPartial.cshtml Outdated
<script src="~/lib/jquery-validation/dist/jquery.validate.js"></script>
<script src="~/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.js"></script>


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit-pick: Extra newline here.

@ryanbrandenburg
Copy link
Contributor

Let me know if you want me to remove CDN tests here

https://github.com/aspnet/AspNetCore/blob/master/src/ProjectTemplates/test/CdnScriptTagTests.cs

Yeah, they no longer serve a purpose so go ahead and remove them.

@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 3, 2019
@isaacrlevin
Copy link
Contributor Author

@ryanbrandenburg do I need a merge from main here? Test failed in a weird spot

@isaacrlevin @Kahbazi
@pranavkm @dotnet-maestro @dougbu @jkotalik @davidfowl @huan086 @analogrelay @SteveSandersonMS @natemcmaster @smitpatel
merge (#3)
9b11e48 
merge 

Co-authored-by: Kahbazi <[email protected]>
Co-authored-by: Pranav K <[email protected]>
Co-authored-by: null <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Doug Bunting <[email protected]>
Co-authored-by: Justin Kotalik <[email protected]>
Co-authored-by: David Fowler <[email protected]>
Co-authored-by: Jeow Li Huan <[email protected]>
Co-authored-by: Andrew Stanton-Nurse <[email protected]>
Co-authored-by: Steve Sanderson <[email protected]>
Co-authored-by: Nate McMaster <[email protected]>
Co-authored-by: Smit Patel <[email protected]>
@isaacrlevin
Copy link
Contributor Author

@ryanbrandenburg doing a merge does not resolve CI

@ryanbrandenburg
Copy link
Contributor

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=211914

@aspnet-hello
Copy link

This comment was made automatically. If there is a problem contact [email protected].

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2450
https://github.com/aspnet/AspNetCore-Internal/issues/2614
https://github.com/aspnet/AspNetCore-Internal/issues/2572
https://github.com/aspnet/AspNetCore-Internal/issues/2626

@ryanbrandenburg
Copy link
Contributor

All the failures were flaky tests, I'm re-running it to see if that cleans things up.

@ryanbrandenburg ryanbrandenburg merged commit f066f7c into dotnet:master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanbrandenburg ryanbrandenburg ryanbrandenburg approved these changes

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isaacrlevin @ryanbrandenburg @aspnet-hello @Eilon