Skip to content

The TaskCompletionSource ctor takes Task*Creation*Options #11294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2019
Merged

The TaskCompletionSource ctor takes Task*Creation*Options #11294

merged 1 commit into from
Jun 19, 2019

Conversation

halter73
Copy link
Member

I would obviously never overlook such an obvious bug /s

davidfowl
davidfowl reviewed Jun 17, 2019
View reviewed changes
Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

@davidfowl
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@analogrelay
Copy link
Contributor

This enum is just the W O R S T.

@davidfowl
Copy link
Member

/azp AspNetCore-ci

@azure-pipelines
Copy link

Command 'AspNetCore-ci' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or a specific pipeline for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify a pipeline to run.
    • Example: "run" or "run pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@davidfowl
Copy link
Member

/azp run AspNetCore-ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@halter73 halter73 merged commit 5f2760e into master Jun 19, 2019
@ghost ghost deleted the halter73/task-CREATION-options branch June 19, 2019 18:44
This was referenced Dec 15, 2021
Open
Open
Open
@rugirundao rugirundao mentioned this pull request May 13, 2022
Open
@rugirundao rugirundao mentioned this pull request Oct 26, 2022
Open
@rugirundao rugirundao mentioned this pull request Nov 5, 2022
Open
@rugirundao rugirundao mentioned this pull request Nov 16, 2022
Open
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfowl davidfowl davidfowl left review comments

@analogrelay analogrelay analogrelay approved these changes

@jkotalik jkotalik jkotalik approved these changes

@JunTaoLuo JunTaoLuo Awaiting requested review from JunTaoLuo

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@halter73 @davidfowl @analogrelay @jkotalik @Eilon @amcasey