Skip to content

On RenderTreeBuilder, add SetUpdatesAttributeName #11375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2019

Conversation

SteveSandersonMS
Copy link
Member

This is part of #8204

Because aspnetcore-tooling is a separate repo, we need a three-phase commit:

  1. First we add SetUpdatesAttributeName in this repo
  2. Then we can merge the PR in aspnetcore-tooling that generates calls to SetUpdatesAttributeName. If we didn't do (1) first, then we'd start getting build errors when the aspnetcore-tooling changes were received here.
  3. Then we can implement the behavior for SetUpdatesAttributeName and it will actually be used.

@Eilon Eilon added the area-blazor Includes: Blazor, Razor Components label Jun 19, 2019
@SteveSandersonMS SteveSandersonMS merged commit 56ffc6b into master Jun 20, 2019
@SteveSandersonMS SteveSandersonMS deleted the stevesa/add-SetUpdatesAttributeName branch June 20, 2019 07:52
/// <para>
/// This information is used by the rendering system to determine whether
/// to accept a value update for the other attribute when receiving a
/// call to the event handler.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SteveSandersonMS - are you concerned that this won't really be possible to do with manual two-way binding?

Copy link
Member Author

@SteveSandersonMS SteveSandersonMS Jun 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and I'd be happy to discuss this whole design with you next week.

My thought was that later on, we'd also add another parameter to event handlers, e.g., @oninput:updateField="value" (or maybe call it @onevent:syncField or similar) so that it is possible to do this with a manual two-way binding. It would be optional, since it's up to you whether or not the binding enforces consistency synchronously when the event is processed.

I also thought it would be acceptable for this to be a @bind-only feature for preview 7, and maybe longer, since adding @onevent:updateField is not urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants