Skip to content

Update Kestrel's dev cert error message #11430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Conversation

mikaelm12
Copy link
Contributor

Fixes: #11145
Just updating the dev cert error message

@@ -487,7 +487,7 @@
<value>The endpoint {endpointName} is missing the required 'Url' parameter.</value>
</data>
<data name="NoCertSpecifiedNoDevelopmentCertificateFound" xml:space="preserve">
<value>Unable to configure HTTPS endpoint. No server certificate was specified, and the default developer certificate could not be found.
<value>Unable to configure HTTPS endpoint. No server certificate was specified, and the default developer certificate could not be found or is out of date.
To generate a developer certificate run 'dotnet dev-certs https'. To trust the certificate (Windows and macOS only) run 'dotnet dev-certs https --trust'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I correct to assume running 'dotnet dev-certs https --trust' replace the out-of-date dev cert? If so, this LGTM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm @javiercn do you have more info on this? If not we can add another line to instruct the user to use --clean to remove any old certs

Copy link
Contributor

@analogrelay analogrelay Jun 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @jkotalik

Am I correct to assume running 'dotnet dev-certs https --trust' replace the out-of-date dev cert? If so, this LGTM.

Yes, I believe this is the case.

@mikaelm12
Copy link
Contributor Author

@aspnet-hello
Copy link

This comment was made automatically. If there is a problem contact [email protected].

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2705

@mikaelm12 mikaelm12 merged commit 655c29b into master Jun 21, 2019
@ghost ghost deleted the mikaelm12/DevCertError branch June 21, 2019 21:28
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider updating Kestrel error message about missing dev cert
6 participants