PR feedback from #11412 #11474
Merged
PR feedback from #11412 #11474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove ExpectedMiddlewareCount since everything is middleware now - Renamed everything adapter to middleware - Added a regression test for an https scenario - Don't send client certs for tests that don't expect it
halter73
reviewed
Jun 24, 2019
|
|
||
| options.ConfigureEndpointDefaults(e => | ||
| { | ||
| if (e.IPEndPoint.Port == 5001) |
There was a problem hiding this comment.
If you didn't have IsDevCertLoaded = true, above, this test would pass even without the custom ConfigureEndpointDefaults, right?
I think this test would be a little more convincing if it made port 5000 the TLS endpoint.
There was a problem hiding this comment.
The default binding only checks 5001 for IsTls
|
Why don't you rename |
halter73
approved these changes
Jun 24, 2019
halter73
approved these changes
Jun 24, 2019
ghost
deleted the
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PS: This was supposed to take 30 mins...