Skip to content

Fixup ref assemblies again #11528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Fixup ref assemblies again #11528

merged 1 commit into from
Jun 25, 2019

Conversation

pranavkm
Copy link
Contributor

Fixes #11240

@pranavkm pranavkm requested a review from danroth27 June 25, 2019 00:00
@pranavkm pranavkm added this to the 3.0.0-preview7 milestone Jun 25, 2019
@pranavkm pranavkm added the area-blazor Includes: Blazor, Razor Components label Jun 25, 2019
Copy link
Member

@danroth27 danroth27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CornedBee
Copy link

This is the important part, fixing the ref assembly. The PageDisplay.cs file is still in the wrong place in the directory hierarchy given its namespace.

@SteveSandersonMS
Copy link
Member

The PageDisplay.cs file is still in the wrong place in the directory hierarchy given its namespace.

We don't always mirror the namespace hierarchy in the directory hierarchy. Sometimes there are constraints that make us want a particular namespace for the consumer that isn't also what we want from a file organization perspective.

However there are inconsistencies that aren't based on any reasoning. It doesn't really make sense that PageDisplay is in the root namespace for components, but LayoutAttribute isn't. These kinds of unintentional variations are part of what we intend to address with #4050.

@pranavkm pranavkm merged commit eba671e into master Jun 25, 2019
@ghost ghost deleted the prkrishn/fixup-refs2 branch June 25, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespace of PageDisplay.cs
5 participants