Skip to content

Enforce selenium tests run on the expected platforms #11602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2019
Merged

Enforce selenium tests run on the expected platforms #11602

merged 1 commit into from
Jul 1, 2019

Conversation

javiercn
Copy link
Member

Throw an exception in places where we conditionally execute selenium tests to ensure they run where we expect them to do.

@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 26, 2019
@javiercn javiercn mentioned this pull request Jun 26, 2019
Closed
@javiercn javiercn force-pushed the javiercn/fix-templates branch from 59d4f91 to b41bbcc Compare July 1, 2019 09:24
@javiercn javiercn requested a review from SteveSandersonMS July 1, 2019 11:50
@javiercn javiercn marked this pull request as ready for review July 1, 2019 11:50
@javiercn javiercn requested a review from ryanbrandenburg as a code owner July 1, 2019 11:50
SteveSandersonMS
SteveSandersonMS approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very useful!

@javiercn javiercn merged commit 635da5b into master Jul 1, 2019
@javiercn javiercn deleted the javiercn/fix-templates branch July 1, 2019 12:42
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2021
Open
@bumplzz69 bumplzz69 mentioned this pull request Nov 4, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Nov 5, 2022
Open
@javakian javakian mentioned this pull request Nov 5, 2022
Open
@sirinartk sirinartk mentioned this pull request Nov 5, 2022
Open
@bumplzz69 bumplzz69 mentioned this pull request Dec 25, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Dec 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 26, 2022
Open
@sirinartk sirinartk mentioned this pull request Dec 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 26, 2022
Open
@javakian javakian mentioned this pull request Jan 10, 2023
Open
@javakian javakian mentioned this pull request Nov 27, 2023
Open
@javakian javakian mentioned this pull request May 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveSandersonMS SteveSandersonMS SteveSandersonMS approved these changes

@ryanbrandenburg ryanbrandenburg Awaiting requested review from ryanbrandenburg

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javiercn @SteveSandersonMS @Eilon