Skip to content

Enforce E2E test prerequisites when building individual solutions only #11642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 28, 2019
Merged

Enforce E2E test prerequisites when building individual solutions only #11642

merged 15 commits into from
Jun 28, 2019

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Jun 27, 2019 •
edited
Loading

Addresses #11342

@javiercn javiercn mentioned this pull request Jun 27, 2019
Closed
@SteveSandersonMS
Copy link
Member

This looks good to me. I suggest also cherry-picking cd5106f into this branch because the devserver-based tests will fail without it (or if they somehow pass without it, that's crazy and we need to investigate).

Also one of the E2E tests about benchmarks will fail until we merge #11649

dougbu
dougbu suggested changes Jun 27, 2019
View reviewed changes
@javiercn javiercn force-pushed the javiercn/enforce-prerequisites-alternative branch from aa81a37 to f1cacbc Compare June 27, 2019 15:25
@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 27, 2019
@javiercn javiercn force-pushed the javiercn/enforce-prerequisites-alternative branch from f1cacbc to 5633662 Compare June 27, 2019 21:59
@dougbu
Copy link
Contributor

dougbu commented Jun 27, 2019

Questions though I suspect this is ready to go (once tests pass):

  1. Have you confirmed the Selenium tests in all the places run on the CI now?
  2. What requires 5633662 and the --applicationPath changes in this PR? Seems fairly unrelated and difficult to review together w/ the simpler MSBuild / scripting changes. I also thought the test fixes were being done in separate PRs.

@javiercn
Copy link
Member Author

  1. Have you confirmed the Selenium tests in all the places run on the CI now?

Yes

2. What requires 5633662 and the --applicationPath changes in this PR? Seems fairly unrelated and difficult to review together w/ the simpler MSBuild / scripting changes. I also thought the test fixes were being done in separate PRs.

Failing tests as part of fixing the E2E tests. I'll have @SteveSandersonMS take a look at that tomorrow. Don't worry about it.

JunTaoLuo
JunTaoLuo approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@JunTaoLuo JunTaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once tests pass.

SteveSandersonMS
SteveSandersonMS approved these changes Jun 28, 2019
View reviewed changes
Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@javiercn javiercn force-pushed the javiercn/enforce-prerequisites-alternative branch 2 times, most recently from 7714037 to a6c3363 Compare June 28, 2019 14:01
@javiercn javiercn force-pushed the javiercn/enforce-prerequisites-alternative branch from 3600125 to e91ed5d Compare June 28, 2019 19:25
@javiercn javiercn merged commit 1480b99 into master Jun 28, 2019
@ghost ghost deleted the javiercn/enforce-prerequisites-alternative branch June 28, 2019 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveSandersonMS SteveSandersonMS SteveSandersonMS approved these changes

@Tratcher Tratcher Tratcher left review comments

@dougbu dougbu dougbu requested changes

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

@ryanbrandenburg ryanbrandenburg Awaiting requested review from ryanbrandenburg

@analogrelay analogrelay Awaiting requested review from analogrelay

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@javiercn @SteveSandersonMS @dougbu @Tratcher @JunTaoLuo @Eilon